As the pci ahci can be hotplug and unplug, in the ahci unrealize
function it should free all the resource once allocated in the
realized function. This patchset first add cleanup function in
core layer and then call it in the ahci unit.

Li Qiang (3):
  ide: qdev: register ide bus unrealize function
  ide: core: add cleanup function
  ide: ahci: call cleanup function in ahci unit

 hw/ide/ahci.c             | 12 ++++++++++++
 hw/ide/core.c             |  8 ++++++++
 hw/ide/qdev.c             | 12 ++++++------
 include/hw/ide/internal.h |  1 +
 4 files changed, 27 insertions(+), 6 deletions(-)

-- 
1.8.3.1

On 03/02/2017 05:08 AM, Li Qiang wrote:
> As the pci ahci can be hotplug and unplug, in the ahci unrealize
> function it should free all the resource once allocated in the
> realized function. This patchset first add cleanup function in
> core layer and then call it in the ahci unit.
> 
> Li Qiang (3):
>   ide: qdev: register ide bus unrealize function
>   ide: core: add cleanup function
>   ide: ahci: call cleanup function in ahci unit
> 
>  hw/ide/ahci.c             | 12 ++++++++++++
>  hw/ide/core.c             |  8 ++++++++
>  hw/ide/qdev.c             | 12 ++++++------
>  include/hw/ide/internal.h |  1 +
>  4 files changed, 27 insertions(+), 6 deletions(-)
> 

Thanks, applied to my IDE tree:

https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git

--js

Hello John,

Does this patch go to upstream?

Thanks.

2017-03-04 6:48 GMT+08:00 John Snow <jsnow@redhat.com>:

>
>
> On 03/02/2017 05:08 AM, Li Qiang wrote:
> > As the pci ahci can be hotplug and unplug, in the ahci unrealize
> > function it should free all the resource once allocated in the
> > realized function. This patchset first add cleanup function in
> > core layer and then call it in the ahci unit.
> >
> > Li Qiang (3):
> >   ide: qdev: register ide bus unrealize function
> >   ide: core: add cleanup function
> >   ide: ahci: call cleanup function in ahci unit
> >
> >  hw/ide/ahci.c             | 12 ++++++++++++
> >  hw/ide/core.c             |  8 ++++++++
> >  hw/ide/qdev.c             | 12 ++++++------
> >  include/hw/ide/internal.h |  1 +
> >  4 files changed, 27 insertions(+), 6 deletions(-)
> >
>
> Thanks, applied to my IDE tree:
>
> https://github.com/jnsnow/qemu/commits/ide
> https://github.com/jnsnow/qemu.git
>
> --js
>

On 03/13/2017 10:41 PM, Li Qiang wrote:
> Hello John,
> 
> Does this patch go to upstream?
> 
> Thanks.
> 

Yes, it will be included for 2.9. I usually send my PRs on Friday, but I
was out of town so it got delayed. It qualifies as a bugfix though, so
it can still go in.

--js

> 2017-03-04 6:48 GMT+08:00 John Snow <jsnow@redhat.com
> <mailto:jsnow@redhat.com>>:
> 
> 
> 
>     On 03/02/2017 05:08 AM, Li Qiang wrote:
>     > As the pci ahci can be hotplug and unplug, in the ahci unrealize
>     > function it should free all the resource once allocated in the
>     > realized function. This patchset first add cleanup function in
>     > core layer and then call it in the ahci unit.
>     >
>     > Li Qiang (3):
>     >   ide: qdev: register ide bus unrealize function
>     >   ide: core: add cleanup function
>     >   ide: ahci: call cleanup function in ahci unit
>     >
>     >  hw/ide/ahci.c             | 12 ++++++++++++
>     >  hw/ide/core.c             |  8 ++++++++
>     >  hw/ide/qdev.c             | 12 ++++++------
>     >  include/hw/ide/internal.h |  1 +
>     >  4 files changed, 27 insertions(+), 6 deletions(-)
>     >
> 
>     Thanks, applied to my IDE tree:
> 
>     https://github.com/jnsnow/qemu/commits/ide
>     <https://github.com/jnsnow/qemu/commits/ide>
>     https://github.com/jnsnow/qemu.git <https://github.com/jnsnow/qemu.git>
> 
>     --js
> 
>