[Qemu-devel] [PULL v2 00/10] vnc: add support for multiple listening sockets.

Gerd Hoffmann posted 10 patches 158 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1486658842-7143-1-git-send-email-kraxel@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
include/qemu/option.h |   9 +
qapi-schema.json      |  28 ++-
qemu-options.hx       |  12 +-
ui/vnc-jobs.c         |  23 --
ui/vnc-jobs.h         |   2 -
ui/vnc.c              | 658 +++++++++++++++++++++++++++++++++++---------------
ui/vnc.h              |  10 +-
util/qemu-option.c    |  19 ++
8 files changed, 533 insertions(+), 228 deletions(-)

[Qemu-devel] [PULL v2 00/10] vnc: add support for multiple listening sockets.

Posted by Gerd Hoffmann 158 weeks ago
  Hi,

Here comes the UI patch queue, carrying only vnc updates this time.  Big
chunk is the multiple sockets support patch series, but there are also
some smaller fixes and cleanups.

v2: squash in the clang fix from Daniel.

please pull,
  Gerd

The following changes since commit d0dff238a87fa81393ed72754d4dc8b09e50b08b:

  Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170206' into staging (2017-02-07 15:29:26 +0000)

are available in the git repository at:


  git://git.kraxel.org/qemu tags/pull-ui-20170209-2

for you to fetch changes up to 396f935a9aff3cefd288bdb2b20024fb9dcfa062:

  ui: add ability to specify multiple VNC listen addresses (2017-02-09 17:28:49 +0100)

----------------------------------------------------------------
vnc: add support for multiple listening sockets.
vnc: misc fixes and cleanups.

----------------------------------------------------------------
Daniel P. Berrange (8):
      ui: fix regression handling bare 'websocket' option to -vnc
      ui: fix reporting of VNC auth in query-vnc-servers
      ui: refactor VncDisplay to allow multiple listening sockets
      ui: refactor code for populating SocketAddress from vnc_display_open
      ui: extract code to connect/listen from vnc_display_open
      ui: let VNC server listen on all resolved IP addresses
      util: add iterators for QemuOpts values
      ui: add ability to specify multiple VNC listen addresses

Michael Tokarev (1):
      vnc: do not disconnect on EAGAIN

Peter Maydell (1):
      ui/vnc: Drop unused vnc_has_job() and vnc_jobs_clear()

 include/qemu/option.h |   9 +
 qapi-schema.json      |  28 ++-
 qemu-options.hx       |  12 +-
 ui/vnc-jobs.c         |  23 --
 ui/vnc-jobs.h         |   2 -
 ui/vnc.c              | 658 +++++++++++++++++++++++++++++++++++---------------
 ui/vnc.h              |  10 +-
 util/qemu-option.c    |  19 ++
 8 files changed, 533 insertions(+), 228 deletions(-)

Re: [Qemu-devel] [PULL v2 00/10] vnc: add support for multiple listening sockets.

Posted by Peter Maydell 158 weeks ago
On 9 February 2017 at 16:47, Gerd Hoffmann <kraxel@redhat.com> wrote:
>   Hi,
>
> Here comes the UI patch queue, carrying only vnc updates this time.  Big
> chunk is the multiple sockets support patch series, but there are also
> some smaller fixes and cleanups.
>
> v2: squash in the clang fix from Daniel.
>
> please pull,
>   Gerd
>
> The following changes since commit d0dff238a87fa81393ed72754d4dc8b09e50b08b:
>
>   Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170206' into staging (2017-02-07 15:29:26 +0000)
>
> are available in the git repository at:
>
>
>   git://git.kraxel.org/qemu tags/pull-ui-20170209-2
>
> for you to fetch changes up to 396f935a9aff3cefd288bdb2b20024fb9dcfa062:
>
>   ui: add ability to specify multiple VNC listen addresses (2017-02-09 17:28:49 +0100)
>
> ----------------------------------------------------------------
> vnc: add support for multiple listening sockets.
> vnc: misc fixes and cleanups.
>
> ----------------------------------------------------------------

Applied, thanks.

-- PMM

Re: [Qemu-devel] [PULL v2 00/10] vnc: add support for multiple listening sockets.

Posted by Paolo Bonzini 157 weeks ago
On 09/02/2017 17:47, Gerd Hoffmann wrote:
>   Hi,
> 
> Here comes the UI patch queue, carrying only vnc updates this time.  Big
> chunk is the multiple sockets support patch series, but there are also
> some smaller fixes and cleanups.
> 
> v2: squash in the clang fix from Daniel.
> 
> please pull,
>   Gerd
> 
> The following changes since commit d0dff238a87fa81393ed72754d4dc8b09e50b08b:
> 
>   Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20170206' into staging (2017-02-07 15:29:26 +0000)
> 
> are available in the git repository at:
> 
> 
>   git://git.kraxel.org/qemu tags/pull-ui-20170209-2
> 
> for you to fetch changes up to 396f935a9aff3cefd288bdb2b20024fb9dcfa062:
> 
>   ui: add ability to specify multiple VNC listen addresses (2017-02-09 17:28:49 +0100)

Coverity reports a double invocation of vnc_display_close in
vnc_display_open.  Perhaps some "goto fail" must be changed to return?

Paolo