target/ppc/fpu_helper.c | 188 ++++++++++++++++++++++++++++++++++++ target/ppc/helper.h | 4 + target/ppc/internal.h | 1 + target/ppc/translate/vsx-impl.inc.c | 5 + target/ppc/translate/vsx-ops.inc.c | 15 +++ 5 files changed, 213 insertions(+)
This set contains 4 new instructions xsrqpi[x] - VSX Scalar Round to Quad-Precision Integer xsrqpxp - VSX Scalar Round Quad-Precision to Double-Extended Precision xssqrtqp - VSX Scalar Square Root Quad-Precision xssubqp - VSX Scalar Subtract Quad-Precision Note: - xssqrtqpo and xssubqpo will be implemented when round-to-odd is ready. Jose Ricardo Ziviani (4): ppc: implement xsrqpi[x] instruction ppc: implement xsrqpxp instruction ppc: implement xssqrtqp instruction ppc: implement xssubqp instruction target/ppc/fpu_helper.c | 188 ++++++++++++++++++++++++++++++++++++ target/ppc/helper.h | 4 + target/ppc/internal.h | 1 + target/ppc/translate/vsx-impl.inc.c | 5 + target/ppc/translate/vsx-ops.inc.c | 15 +++ 5 files changed, 213 insertions(+) -- 2.7.4
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH 0/4] POWER9 TCG enablements - part 13 Message-id: 1486159277-25949-1-git-send-email-joserz@linux.vnet.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1486159277-25949-1-git-send-email-joserz@linux.vnet.ibm.com -> patchew/1486159277-25949-1-git-send-email-joserz@linux.vnet.ibm.com - [tag update] patchew/20170203120254.15062-1-berrange@redhat.com -> patchew/20170203120254.15062-1-berrange@redhat.com Switched to a new branch 'test' 52f618a ppc: implement xssubqp instruction f7dfdbf ppc: implement xssqrtqp instruction 4d895a4 ppc: implement xsrqpxp instruction 5d49c07 ppc: implement xsrqpi[x] instruction === OUTPUT BEGIN === Checking PATCH 1/4: ppc: implement xsrqpi[x] instruction... ERROR: Macros with complex values should be enclosed in parenthesis #125: FILE: target/ppc/translate/vsx-ops.inc.c:106: +#define GEN_VSX_Z23FORM_300(name, opc2, opc3, opc4, inval) \ +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x00, opc4 | 0x0, inval), \ +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x08, opc4 | 0x0, inval), \ +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x10, opc4 | 0x0, inval), \ +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x18, opc4 | 0x0, inval), \ +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x00, opc4 | 0x1, inval), \ +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x08, opc4 | 0x1, inval), \ +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x10, opc4 | 0x1, inval), \ +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x18, opc4 | 0x1, inval) total: 1 errors, 0 warnings, 103 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/4: ppc: implement xsrqpxp instruction... Checking PATCH 3/4: ppc: implement xssqrtqp instruction... Checking PATCH 4/4: ppc: implement xssubqp instruction... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@freelists.org
On Fri, Feb 03, 2017 at 02:11:31PM -0800, no-reply@patchew.org wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PATCH 0/4] POWER9 TCG enablements - part 13 > Message-id: 1486159277-25949-1-git-send-email-joserz@linux.vnet.ibm.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > # Useful git options > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > * [new tag] patchew/1486159277-25949-1-git-send-email-joserz@linux.vnet.ibm.com -> patchew/1486159277-25949-1-git-send-email-joserz@linux.vnet.ibm.com > - [tag update] patchew/20170203120254.15062-1-berrange@redhat.com -> patchew/20170203120254.15062-1-berrange@redhat.com > Switched to a new branch 'test' > 52f618a ppc: implement xssubqp instruction > f7dfdbf ppc: implement xssqrtqp instruction > 4d895a4 ppc: implement xsrqpxp instruction > 5d49c07 ppc: implement xsrqpi[x] instruction > > === OUTPUT BEGIN === > Checking PATCH 1/4: ppc: implement xsrqpi[x] instruction... > ERROR: Macros with complex values should be enclosed in parenthesis > #125: FILE: target/ppc/translate/vsx-ops.inc.c:106: > +#define GEN_VSX_Z23FORM_300(name, opc2, opc3, opc4, inval) \ > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x00, opc4 | 0x0, inval), \ > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x08, opc4 | 0x0, inval), \ > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x10, opc4 | 0x0, inval), \ > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x18, opc4 | 0x0, inval), \ > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x00, opc4 | 0x1, inval), \ > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x08, opc4 | 0x1, inval), \ > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x10, opc4 | 0x1, inval), \ > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x18, opc4 | 0x1, inval) > I tried to improve it but this style is used everywhere > total: 1 errors, 0 warnings, 103 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Checking PATCH 2/4: ppc: implement xsrqpxp instruction... > Checking PATCH 3/4: ppc: implement xssqrtqp instruction... > Checking PATCH 4/4: ppc: implement xssubqp instruction... > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-devel@freelists.org
On Fri, Feb 03, 2017 at 11:29:37PM -0200, joserz@linux.vnet.ibm.com wrote: > On Fri, Feb 03, 2017 at 02:11:31PM -0800, no-reply@patchew.org wrote: > > Hi, > > > > Your series seems to have some coding style problems. See output below for > > more information: > > > > Type: series > > Subject: [Qemu-devel] [PATCH 0/4] POWER9 TCG enablements - part 13 > > Message-id: 1486159277-25949-1-git-send-email-joserz@linux.vnet.ibm.com > > > > === TEST SCRIPT BEGIN === > > #!/bin/bash > > > > BASE=base > > n=1 > > total=$(git log --oneline $BASE.. | wc -l) > > failed=0 > > > > # Useful git options > > git config --local diff.renamelimit 0 > > git config --local diff.renames True > > > > commits="$(git log --format=%H --reverse $BASE..)" > > for c in $commits; do > > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > > failed=1 > > echo > > fi > > n=$((n+1)) > > done > > > > exit $failed > > === TEST SCRIPT END === > > > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > > From https://github.com/patchew-project/qemu > > * [new tag] patchew/1486159277-25949-1-git-send-email-joserz@linux.vnet.ibm.com -> patchew/1486159277-25949-1-git-send-email-joserz@linux.vnet.ibm.com > > - [tag update] patchew/20170203120254.15062-1-berrange@redhat.com -> patchew/20170203120254.15062-1-berrange@redhat.com > > Switched to a new branch 'test' > > 52f618a ppc: implement xssubqp instruction > > f7dfdbf ppc: implement xssqrtqp instruction > > 4d895a4 ppc: implement xsrqpxp instruction > > 5d49c07 ppc: implement xsrqpi[x] instruction > > > > === OUTPUT BEGIN === > > Checking PATCH 1/4: ppc: implement xsrqpi[x] instruction... > > ERROR: Macros with complex values should be enclosed in parenthesis > > #125: FILE: target/ppc/translate/vsx-ops.inc.c:106: > > +#define GEN_VSX_Z23FORM_300(name, opc2, opc3, opc4, inval) \ > > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x00, opc4 | 0x0, inval), \ > > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x08, opc4 | 0x0, inval), \ > > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x10, opc4 | 0x0, inval), \ > > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x18, opc4 | 0x0, inval), \ > > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x00, opc4 | 0x1, inval), \ > > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x08, opc4 | 0x1, inval), \ > > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x10, opc4 | 0x1, inval), \ > > +GEN_VSX_XFORM_300_EO(name, opc2, opc3 | 0x18, opc4 | 0x1, inval) > > > > I tried to improve it but this style is used everywhere Yeah, that's ok. These instruction generation macros trigger known false positives in checkpatch. I think it thinks these are macro definitions, rather than macro invocations. > > > total: 1 errors, 0 warnings, 103 lines checked > > > > Your patch has style problems, please review. If any of these errors > > are false positives report them to the maintainer, see > > CHECKPATCH in MAINTAINERS. > > > > Checking PATCH 2/4: ppc: implement xsrqpxp instruction... > > Checking PATCH 3/4: ppc: implement xssqrtqp instruction... > > Checking PATCH 4/4: ppc: implement xssubqp instruction... > > === OUTPUT END === > > > > Test command exited with code: 1 > > > > > > --- > > Email generated automatically by Patchew [http://patchew.org/]. > > Please send your feedback to patchew-devel@freelists.org > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
On Fri, Feb 03, 2017 at 08:01:13PM -0200, Jose Ricardo Ziviani wrote: > This set contains 4 new instructions > > xsrqpi[x] - VSX Scalar Round to Quad-Precision Integer > xsrqpxp - VSX Scalar Round Quad-Precision to Double-Extended Precision > xssqrtqp - VSX Scalar Square Root Quad-Precision > xssubqp - VSX Scalar Subtract Quad-Precision > > Note: > - xssqrtqpo and xssubqpo will be implemented when round-to-odd is > ready. Applied to ppc-for-2.9. Note that I haven't reviewed these particularly closely. Since they're new instructions, I figure it won't cause a regression, even if they're buggy. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
© 2016 - 2024 Red Hat, Inc.