audio related fixes for 10.1

[PATCH v2 0/7] audio related fixes for 10.1

Volker Rümelin posted 7 patches 7 months, 1 week ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/0bb1a55e-70f1-410b-8b59-78eed7f4c8f7@t-online.de

Maintainers: Gerd Hoffmann <kraxel@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Laurent Vivier <laurent@vivier.eu>, Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>

audio/audio.c                        | 11 +++-
audio/audio_template.h               | 12 ++--
audio/mixeng.c                       | 83 ++++++++++++++++++++++++----
audio/mixeng.h                       |  6 +-
hw/audio/asc.c                       |  9 ++-
tests/functional/test_m68k_q800.py   |  3 +-
tests/functional/test_m68k_replay.py |  3 +-
7 files changed, 106 insertions(+), 21 deletions(-)

Expand all Fold all

[PATCH v2 0/7] audio related fixes for 10.1

Posted by Volker Rümelin 7 months, 1 week ago

A few audio related fixes for 10.1.

The virtio-sound device is the first QEMU audio front end that supports floating point samples. The audio subsystem is only partially prepared for this. The commit message of patch 7/7 "audio: add float sample endianness converters" has the details. The new code paths in patch 7/7 are only compile tested. I don't have a big endian host to test.

checkpatch.pl complains about missing space characters in the type punning macros in patch 7/7. I don't agree.

v2: Address Mark's comments

patch 4/7 "hw/audio/asc: fix SIGSEGV in asc_realize()"
Only call AUD_remove_card() to handle cleanup.

Volker Rümelin (7):
  tests/functional: use 'none' audio driver for q800 tests
  audio: fix SIGSEGV in AUD_get_buffer_size_out()
  audio: fix size calculation in AUD_get_buffer_size_out()
  hw/audio/asc: fix SIGSEGV in asc_realize()
  hw/audio/asc: replace g_malloc0() with g_malloc()
  audio/mixeng: remove unnecessary pointer type casts
  audio: add float sample endianness converters

 audio/audio.c                        | 11 +++-
 audio/audio_template.h               | 12 ++--
 audio/mixeng.c                       | 83 ++++++++++++++++++++++++----
 audio/mixeng.h                       |  6 +-
 hw/audio/asc.c                       |  9 ++-
 tests/functional/test_m68k_q800.py   |  3 +-
 tests/functional/test_m68k_replay.py |  3 +-
 7 files changed, 106 insertions(+), 21 deletions(-)

-- 
2.43.0

Re: [PATCH v2 0/7] audio related fixes for 10.1

Posted by Michael Tokarev 6 months, 3 weeks ago

On 15.05.2025 08:42, Volker Rümelin wrote:
> A few audio related fixes for 10.1.
> 
> The virtio-sound device is the first QEMU audio front end that supports floating point samples. The audio subsystem is only partially prepared for this. The commit message of patch 7/7 "audio: add float sample endianness converters" has the details. The new code paths in patch 7/7 are only compile tested. I don't have a big endian host to test.
..
> Volker Rümelin (7):
>    tests/functional: use 'none' audio driver for q800 tests
>    audio: fix SIGSEGV in AUD_get_buffer_size_out()
>    audio: fix size calculation in AUD_get_buffer_size_out()
>    hw/audio/asc: fix SIGSEGV in asc_realize()
>    hw/audio/asc: replace g_malloc0() with g_malloc()
>    audio/mixeng: remove unnecessary pointer type casts
>    audio: add float sample endianness converters

Is there anything here which is worth to apply to qemu-stable?
(10.0.x is supposed to be an LTS series).

Thanks,

/mjt