configure: add ppc target back to container tests

[PATCH trivial] configure: add ppc target back to container tests

Posted by Florian Hofhammer 2 weeks, 4 days ago

Commit 2ff8c9a298 removed support for 32-bit PPC hosts from the build
system. Unfortunately, the patch also removed the 32-bit PPC target for
containerized tests, which leads to an error when trying to run tests,
e.g., with "make check-tcg":
"make[1]: *** No rule to make target 'docker-image-debian-ppc-cross',
needed by 'build-tcg-tests-ppc-linux-user'.  Stop."

This patch adds the PPC target back for containerized tests.

Fixes: 2ff8c9a2984bb20e350ae52152812c5370b02e32
Signed-off-by: Florian Hofhammer <florian.hofhammer@fhofhammer.de>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index e69b3e474e..1b0af0cf46 100755
--- a/configure
+++ b/configure
@@ -1451,7 +1451,7 @@ probe_target_compiler() {
         container_image=debian-all-test-cross
         container_cross_prefix=mips64-linux-gnuabi64-
         ;;
-      ppc64|ppc64le)
+      ppc|ppc64|ppc64le)
         container_image=debian-all-test-cross
         container_cross_prefix=powerpc${target_arch#ppc}-linux-gnu-
         ;;
-- 
2.51.0

Re: [PATCH trivial] configure: add ppc target back to container tests

Posted by Thomas Huth 2 weeks, 4 days ago

On 19/01/2026 11.25, Florian Hofhammer wrote:
> Commit 2ff8c9a298 removed support for 32-bit PPC hosts from the build
> system. Unfortunately, the patch also removed the 32-bit PPC target for
> containerized tests, which leads to an error when trying to run tests,
> e.g., with "make check-tcg":
> "make[1]: *** No rule to make target 'docker-image-debian-ppc-cross',
> needed by 'build-tcg-tests-ppc-linux-user'.  Stop."
> 
> This patch adds the PPC target back for containerized tests.
> 
> Fixes: 2ff8c9a2984bb20e350ae52152812c5370b02e32
> Signed-off-by: Florian Hofhammer <florian.hofhammer@fhofhammer.de>
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index e69b3e474e..1b0af0cf46 100755
> --- a/configure
> +++ b/configure
> @@ -1451,7 +1451,7 @@ probe_target_compiler() {
>           container_image=debian-all-test-cross
>           container_cross_prefix=mips64-linux-gnuabi64-
>           ;;
> -      ppc64|ppc64le)
> +      ppc|ppc64|ppc64le)
>           container_image=debian-all-test-cross
>           container_cross_prefix=powerpc${target_arch#ppc}-linux-gnu-
>           ;;

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH trivial] configure: add ppc target back to container tests

Posted by Philippe Mathieu-Daudé 2 weeks, 4 days ago

On 19/1/26 15:29, Thomas Huth wrote:
> On 19/01/2026 11.25, Florian Hofhammer wrote:
>> Commit 2ff8c9a298 removed support for 32-bit PPC hosts from the build
>> system. Unfortunately, the patch also removed the 32-bit PPC target for
>> containerized tests, which leads to an error when trying to run tests,
>> e.g., with "make check-tcg":
>> "make[1]: *** No rule to make target 'docker-image-debian-ppc-cross',
>> needed by 'build-tcg-tests-ppc-linux-user'.  Stop."

Oops.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>>
>> This patch adds the PPC target back for containerized tests.
>>
>> Fixes: 2ff8c9a2984bb20e350ae52152812c5370b02e32
>> Signed-off-by: Florian Hofhammer <florian.hofhammer@fhofhammer.de>
>> ---
>>   configure | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index e69b3e474e..1b0af0cf46 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1451,7 +1451,7 @@ probe_target_compiler() {
>>           container_image=debian-all-test-cross
>>           container_cross_prefix=mips64-linux-gnuabi64-
>>           ;;
>> -      ppc64|ppc64le)
>> +      ppc|ppc64|ppc64le)
>>           container_image=debian-all-test-cross
>>           container_cross_prefix=powerpc${target_arch#ppc}-linux-gnu-
>>           ;;
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>