[PATCH] qom/object.c: Fix typo

Doug Evans via posted 1 patch 4 years, 9 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/000000000000530c7105bb191b33@google.com
Maintainers: Eduardo Habkost <ehabkost@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
[PATCH] qom/object.c: Fix typo
Posted by Doug Evans via 4 years, 9 months ago
A simple typo (noticed by inspection).

commit ccdffd2c10c5e4447d5e462a6ad2f351df502dee
Author: Doug Evans <dje@google.com>
Date:   Thu Feb 11 16:29:13 2021 -0800

    qom/object.c: Fix typo
    
    Signed-off-by: Doug Evans <dje@google.com>

diff --git a/qom/object.c b/qom/object.c
index 491823db4a..6a01d56546 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -695,7 +695,7 @@ static void object_finalize(void *data)
 
 /* Find the minimum alignment guaranteed by the system malloc. */
 #if __STDC_VERSION__ >= 201112L
-typddef max_align_t qemu_max_align_t;
+typedef max_align_t qemu_max_align_t;
 #else
 typedef union {
     long l;

Re: [PATCH] qom/object.c: Fix typo
Posted by Philippe Mathieu-Daudé 4 years, 9 months ago
Hi Doug,

On 2/12/21 1:56 AM, Doug Evans via wrote:
> A simple typo (noticed by inspection).
> 
> commit ccdffd2c10c5e4447d5e462a6ad2f351df502dee
> Author: Doug Evans <dje@google.com>
> Date:   Thu Feb 11 16:29:13 2021 -0800
> 
>     qom/object.c: Fix typo
>     
>     Signed-off-by: Doug Evans <dje@google.com>

Your patch can be applied with git-am, but with author
Doug Evans via <qemu-devel@nongnu.org> and contains an invalid
commit reference.

Can you use git-format-patch which inserts a From: tag so your
email is properly set and you don't have to worry with the issues
with your email provider:
https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch

> diff --git a/qom/object.c b/qom/object.c
> index 491823db4a..6a01d56546 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -695,7 +695,7 @@ static void object_finalize(void *data)
>  
>  /* Find the minimum alignment guaranteed by the system malloc. */
>  #if __STDC_VERSION__ >= 201112L
> -typddef max_align_t qemu_max_align_t;
> +typedef max_align_t qemu_max_align_t;
>  #else
>  typedef union {
>      long l;
> 

For the typo:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>