1. Patchew
  2. Patchew
  3. [Patchew-devel] [PATCH 0/4] small code formatting fixes
  4. View patch

[Patchew-devel] [PATCH 2/4] remove unused imports

Paolo Bonzini posted 4 patches 6 years, 8 months ago
[Patchew-devel] [PATCH 2/4] remove unused imports
Posted by Paolo Bonzini 6 years, 8 months ago 
Patch generated by autoflake.
---
 api/migrations/0028_populate_git_results.py     | 2 --
 api/migrations/0029_populate_testing_results.py | 2 --
 api/migrations/0030_deblob_properties.py        | 3 ---
 api/migrations/0036_populate_message_tags.py    | 2 --
 api/migrations/0038_populate_default_groups.py  | 2 --
 api/migrations/0041_postgres_fts.py             | 3 +--
 api/migrations/0042_review_to_queue.py          | 3 +--
 api/migrations/0047_populate_project_config.py  | 1 -
 api/migrations/0049_populate_message_flags.py   | 1 -
 api/migrations/0051_populate_property_fields.py | 2 --
 mods/git.py                                     | 7 ++-----
 tests/test_import.py                            | 1 -
 www/views.py                                    | 1 -
 13 files changed, 4 insertions(+), 26 deletions(-)

diff --git a/api/migrations/0028_populate_git_results.py b/api/migrations/0028_populate_git_results.py
index bc17e08..dd6f9bc 100644
--- a/api/migrations/0028_populate_git_results.py
+++ b/api/migrations/0028_populate_git_results.py
@@ -1,9 +1,7 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.conf import settings
 from django.db import migrations
-from django.db.models import Count
 from api.migrations import get_property, set_property, delete_property_blob
 
 import datetime
diff --git a/api/migrations/0029_populate_testing_results.py b/api/migrations/0029_populate_testing_results.py
index 0607936..0002de2 100644
--- a/api/migrations/0029_populate_testing_results.py
+++ b/api/migrations/0029_populate_testing_results.py
@@ -1,9 +1,7 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.conf import settings
 from django.db import migrations
-from django.db.models import Count
 from api.migrations import (get_property, get_property_raw,
         load_property, set_property, delete_property_blob)
 
diff --git a/api/migrations/0030_deblob_properties.py b/api/migrations/0030_deblob_properties.py
index 801f7a2..2750058 100644
--- a/api/migrations/0030_deblob_properties.py
+++ b/api/migrations/0030_deblob_properties.py
@@ -1,11 +1,8 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.conf import settings
 from django.db import migrations
-from django.db.models import Count
 
-import json
 from api import blobs
 
 def deblob_properties(apps, schema_editor):
diff --git a/api/migrations/0036_populate_message_tags.py b/api/migrations/0036_populate_message_tags.py
index e9f2a70..681d70c 100644
--- a/api/migrations/0036_populate_message_tags.py
+++ b/api/migrations/0036_populate_message_tags.py
@@ -2,8 +2,6 @@
 from __future__ import unicode_literals
 
 from django.db import migrations
-from django.db.models import Count
-import json
 
 
 def tags_from_property(apps, schema_editor):
diff --git a/api/migrations/0038_populate_default_groups.py b/api/migrations/0038_populate_default_groups.py
index b805da7..5fee0a3 100644
--- a/api/migrations/0038_populate_default_groups.py
+++ b/api/migrations/0038_populate_default_groups.py
@@ -2,8 +2,6 @@
 from __future__ import unicode_literals
 
 from django.db import migrations
-from django.db.models import Count
-import json
 
 
 def populate_default_groups(apps, schema_editor):
diff --git a/api/migrations/0041_postgres_fts.py b/api/migrations/0041_postgres_fts.py
index d3b2fa8..9424b9e 100644
--- a/api/migrations/0041_postgres_fts.py
+++ b/api/migrations/0041_postgres_fts.py
@@ -2,8 +2,7 @@
 # Generated by Django 1.11.16 on 2018-11-07 15:28
 from __future__ import unicode_literals
 
-from django.db import migrations, models
-import django.db.models.deletion
+from django.db import migrations
 from django.contrib.postgres.operations import TrigramExtension
 
 from api.migrations import PostgresOnlyMigration
diff --git a/api/migrations/0042_review_to_queue.py b/api/migrations/0042_review_to_queue.py
index 8e1a33d..d9f193f 100644
--- a/api/migrations/0042_review_to_queue.py
+++ b/api/migrations/0042_review_to_queue.py
@@ -3,8 +3,7 @@
 from __future__ import unicode_literals
 
 from django.conf import settings
-from django.db import migrations, models
-import django.db.models.deletion
+from django.db import migrations
 
 
 class Migration(migrations.Migration):
diff --git a/api/migrations/0047_populate_project_config.py b/api/migrations/0047_populate_project_config.py
index 2a86e1f..ee2f264 100644
--- a/api/migrations/0047_populate_project_config.py
+++ b/api/migrations/0047_populate_project_config.py
@@ -1,7 +1,6 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.conf import settings
 from django.db import migrations
 from django.db.models import Q
 
diff --git a/api/migrations/0049_populate_message_flags.py b/api/migrations/0049_populate_message_flags.py
index 88e9a6b..d5302cf 100644
--- a/api/migrations/0049_populate_message_flags.py
+++ b/api/migrations/0049_populate_message_flags.py
@@ -1,7 +1,6 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.conf import settings
 from django.db import migrations
 
 def property_to_flags(apps, schema_editor):
diff --git a/api/migrations/0051_populate_property_fields.py b/api/migrations/0051_populate_property_fields.py
index 2f36ceb..5bf07c4 100644
--- a/api/migrations/0051_populate_property_fields.py
+++ b/api/migrations/0051_populate_property_fields.py
@@ -1,9 +1,7 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.conf import settings
 from django.db import migrations, transaction
-from django.db.models import Q
 
 def do_properties_to_field(obj, propset):
     properties = {}
diff --git a/mods/git.py b/mods/git.py
index 753da7e..14d54b6 100644
--- a/mods/git.py
+++ b/mods/git.py
@@ -10,23 +10,20 @@
 
 import os
 import subprocess
-import hashlib
-import json
 import rest_framework
 from django.conf.urls import url
 from django.http import Http404, HttpResponseRedirect
 from django.urls import reverse
 from django.core.exceptions import PermissionDenied
 from django.utils.html import format_html
-from django.db.models import Q
 from mod import PatchewModule
-from event import declare_event, register_handler, emit_event
+from event import declare_event, register_handler
 from api.models import (Message, Project, Result)
 from api.rest import PluginMethodField, SeriesSerializer, reverse_detail
 from api.views import APILoginRequiredView, prepare_series
 from patchew.logviewer import LogView
 import schema
-from rest_framework import generics, mixins, serializers
+from rest_framework import generics, serializers
 from rest_framework.fields import CharField, SerializerMethodField
 
 _instance = None
diff --git a/tests/test_import.py b/tests/test_import.py
index 466b45f..84bc70b 100755
--- a/tests/test_import.py
+++ b/tests/test_import.py
@@ -8,7 +8,6 @@
 # This work is licensed under the MIT License.  Please see the LICENSE file or
 # http://opensource.org/licenses/MIT.
 
-import json
 
 from api.models import Message, Project
 
diff --git a/www/views.py b/www/views.py
index 4436c7b..ccbbc6f 100644
--- a/www/views.py
+++ b/www/views.py
@@ -16,7 +16,6 @@ from django.urls import reverse
 from django.utils.html import format_html
 from django.conf import settings
 import api
-import re
 from mod import dispatch_module_hook
 import subprocess
 
-- 
2.21.0


_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel
Re: [Patchew-devel] [PATCH 2/4] remove unused imports
Posted by Philippe Mathieu-Daudé 6 years, 8 months ago 
On 5/25/19 10:39 AM, Paolo Bonzini wrote:
> Patch generated by autoflake.
> ---
>  api/migrations/0028_populate_git_results.py     | 2 --
>  api/migrations/0029_populate_testing_results.py | 2 --
>  api/migrations/0030_deblob_properties.py        | 3 ---
>  api/migrations/0036_populate_message_tags.py    | 2 --
>  api/migrations/0038_populate_default_groups.py  | 2 --
>  api/migrations/0041_postgres_fts.py             | 3 +--
>  api/migrations/0042_review_to_queue.py          | 3 +--
>  api/migrations/0047_populate_project_config.py  | 1 -
>  api/migrations/0049_populate_message_flags.py   | 1 -
>  api/migrations/0051_populate_property_fields.py | 2 --
>  mods/git.py                                     | 7 ++-----
>  tests/test_import.py                            | 1 -
>  www/views.py                                    | 1 -
>  13 files changed, 4 insertions(+), 26 deletions(-)
> 
> diff --git a/api/migrations/0028_populate_git_results.py b/api/migrations/0028_populate_git_results.py
> index bc17e08..dd6f9bc 100644
> --- a/api/migrations/0028_populate_git_results.py
> +++ b/api/migrations/0028_populate_git_results.py
> @@ -1,9 +1,7 @@
>  # -*- coding: utf-8 -*-
>  from __future__ import unicode_literals
>  
> -from django.conf import settings
>  from django.db import migrations
> -from django.db.models import Count
>  from api.migrations import get_property, set_property, delete_property_blob
>  
>  import datetime
> diff --git a/api/migrations/0029_populate_testing_results.py b/api/migrations/0029_populate_testing_results.py
> index 0607936..0002de2 100644
> --- a/api/migrations/0029_populate_testing_results.py
> +++ b/api/migrations/0029_populate_testing_results.py
> @@ -1,9 +1,7 @@
>  # -*- coding: utf-8 -*-
>  from __future__ import unicode_literals
>  
> -from django.conf import settings
>  from django.db import migrations
> -from django.db.models import Count
>  from api.migrations import (get_property, get_property_raw,
>          load_property, set_property, delete_property_blob)
>  
> diff --git a/api/migrations/0030_deblob_properties.py b/api/migrations/0030_deblob_properties.py
> index 801f7a2..2750058 100644
> --- a/api/migrations/0030_deblob_properties.py
> +++ b/api/migrations/0030_deblob_properties.py
> @@ -1,11 +1,8 @@
>  # -*- coding: utf-8 -*-
>  from __future__ import unicode_literals
>  
> -from django.conf import settings
>  from django.db import migrations
> -from django.db.models import Count
>  
> -import json
>  from api import blobs
>  
>  def deblob_properties(apps, schema_editor):
> diff --git a/api/migrations/0036_populate_message_tags.py b/api/migrations/0036_populate_message_tags.py
> index e9f2a70..681d70c 100644
> --- a/api/migrations/0036_populate_message_tags.py
> +++ b/api/migrations/0036_populate_message_tags.py
> @@ -2,8 +2,6 @@
>  from __future__ import unicode_literals
>  
>  from django.db import migrations
> -from django.db.models import Count
> -import json
>  
>  
>  def tags_from_property(apps, schema_editor):
> diff --git a/api/migrations/0038_populate_default_groups.py b/api/migrations/0038_populate_default_groups.py
> index b805da7..5fee0a3 100644
> --- a/api/migrations/0038_populate_default_groups.py
> +++ b/api/migrations/0038_populate_default_groups.py
> @@ -2,8 +2,6 @@
>  from __future__ import unicode_literals
>  
>  from django.db import migrations
> -from django.db.models import Count
> -import json
>  
>  
>  def populate_default_groups(apps, schema_editor):
> diff --git a/api/migrations/0041_postgres_fts.py b/api/migrations/0041_postgres_fts.py
> index d3b2fa8..9424b9e 100644
> --- a/api/migrations/0041_postgres_fts.py
> +++ b/api/migrations/0041_postgres_fts.py
> @@ -2,8 +2,7 @@
>  # Generated by Django 1.11.16 on 2018-11-07 15:28
>  from __future__ import unicode_literals
>  
> -from django.db import migrations, models
> -import django.db.models.deletion
> +from django.db import migrations
>  from django.contrib.postgres.operations import TrigramExtension
>  
>  from api.migrations import PostgresOnlyMigration
> diff --git a/api/migrations/0042_review_to_queue.py b/api/migrations/0042_review_to_queue.py
> index 8e1a33d..d9f193f 100644
> --- a/api/migrations/0042_review_to_queue.py
> +++ b/api/migrations/0042_review_to_queue.py
> @@ -3,8 +3,7 @@
>  from __future__ import unicode_literals
>  
>  from django.conf import settings
> -from django.db import migrations, models
> -import django.db.models.deletion
> +from django.db import migrations
>  
>  
>  class Migration(migrations.Migration):
> diff --git a/api/migrations/0047_populate_project_config.py b/api/migrations/0047_populate_project_config.py
> index 2a86e1f..ee2f264 100644
> --- a/api/migrations/0047_populate_project_config.py
> +++ b/api/migrations/0047_populate_project_config.py
> @@ -1,7 +1,6 @@
>  # -*- coding: utf-8 -*-
>  from __future__ import unicode_literals
>  
> -from django.conf import settings
>  from django.db import migrations
>  from django.db.models import Q
>  
> diff --git a/api/migrations/0049_populate_message_flags.py b/api/migrations/0049_populate_message_flags.py
> index 88e9a6b..d5302cf 100644
> --- a/api/migrations/0049_populate_message_flags.py
> +++ b/api/migrations/0049_populate_message_flags.py
> @@ -1,7 +1,6 @@
>  # -*- coding: utf-8 -*-
>  from __future__ import unicode_literals
>  
> -from django.conf import settings
>  from django.db import migrations
>  
>  def property_to_flags(apps, schema_editor):
> diff --git a/api/migrations/0051_populate_property_fields.py b/api/migrations/0051_populate_property_fields.py
> index 2f36ceb..5bf07c4 100644
> --- a/api/migrations/0051_populate_property_fields.py
> +++ b/api/migrations/0051_populate_property_fields.py
> @@ -1,9 +1,7 @@
>  # -*- coding: utf-8 -*-
>  from __future__ import unicode_literals
>  
> -from django.conf import settings
>  from django.db import migrations, transaction
> -from django.db.models import Q
>  
>  def do_properties_to_field(obj, propset):
>      properties = {}
> diff --git a/mods/git.py b/mods/git.py
> index 753da7e..14d54b6 100644
> --- a/mods/git.py
> +++ b/mods/git.py
> @@ -10,23 +10,20 @@
>  
>  import os
>  import subprocess
> -import hashlib
> -import json
>  import rest_framework
>  from django.conf.urls import url
>  from django.http import Http404, HttpResponseRedirect
>  from django.urls import reverse
>  from django.core.exceptions import PermissionDenied
>  from django.utils.html import format_html
> -from django.db.models import Q
>  from mod import PatchewModule
> -from event import declare_event, register_handler, emit_event
> +from event import declare_event, register_handler
>  from api.models import (Message, Project, Result)
>  from api.rest import PluginMethodField, SeriesSerializer, reverse_detail
>  from api.views import APILoginRequiredView, prepare_series
>  from patchew.logviewer import LogView
>  import schema
> -from rest_framework import generics, mixins, serializers
> +from rest_framework import generics, serializers
>  from rest_framework.fields import CharField, SerializerMethodField
>  
>  _instance = None
> diff --git a/tests/test_import.py b/tests/test_import.py
> index 466b45f..84bc70b 100755
> --- a/tests/test_import.py
> +++ b/tests/test_import.py
> @@ -8,7 +8,6 @@
>  # This work is licensed under the MIT License.  Please see the LICENSE file or
>  # http://opensource.org/licenses/MIT.
>  
> -import json
>  
>  from api.models import Message, Project
>  
> diff --git a/www/views.py b/www/views.py
> index 4436c7b..ccbbc6f 100644
> --- a/www/views.py
> +++ b/www/views.py
> @@ -16,7 +16,6 @@ from django.urls import reverse
>  from django.utils.html import format_html
>  from django.conf import settings
>  import api
> -import re
>  from mod import dispatch_module_hook
>  import subprocess
>  
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.