1. Patchew
  2. Patchew
  3. [Patchew-devel] [PATCH 0/7] Cleanups around properties
  4. View patch

[Patchew-devel] [PATCH 5/7] tests: remove case insensitive tags test

Paolo Bonzini posted 7 patches 6 years, 9 months ago
[Patchew-devel] [PATCH 5/7] tests: remove case insensitive tags test
Posted by Paolo Bonzini 6 years, 9 months ago 
I am not sure what this is testing, and it is the only user of properties search.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/data/0002-unusual-cased-tags.mbox.gz | Bin 2166 -> 0 bytes
 tests/test_import.py                       |  11 -----------
 2 files changed, 11 deletions(-)
 delete mode 100644 tests/data/0002-unusual-cased-tags.mbox.gz

diff --git a/tests/data/0002-unusual-cased-tags.mbox.gz b/tests/data/0002-unusual-cased-tags.mbox.gz
deleted file mode 100644
index 3968ed24c891b6b9f07e4837421280f1efa70e87..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 2166
zcmV-+2#NO}iwFpRGICb{128Z!GA(s(b#rxLY%OD9b7f>LbYW+6E^T6OcmSnX`*Y$r
z68<^<EBdysu3(9bZ44MsvX=)T$!#8N%sh5dDasFlH8GaQvIETR{qNVZc_w6PHj}Es
zmfY&c*WI6_>C%Wj(Ub;cz-?fYgr^xzj}kZYLpoJ?I#%wePf;cyPQPbE-xUHX-+0JX
zpHFNE_{3!~@DY5albi(fiAKcZdF)eh6!Ul-=TZv<RIqXEW>kQoS*osEs?lhwdK+8;
z2~8&~%V+?C#sN*C3gAbK#u;IW{cOQAhmuzvdXwqu+VJ7F^gEz22FDXhMk${hzKplF
z#P4tezYP%HL5S-QBPKGTF6S_uEKg(7ceBujgTJr!w-q2ZNXKAHKUB7d_uD}|RKc6W
zWTr|05x7W#sO(Ky7J_p<=sUmy(9Kp`Yg?VRZW^Z5GE}Q$v@NUC>@>A@^Br9Ccpr>5
z{3nkQVZ8;qWj9;4t^?89ng*4AcTj!dCHLJZ<RXL0y>06ccB9d<Iy(@mDtqYSb`*tw
zR7|o2DrYk`0aI=3C|KD_(VNgjEiz>9f^|%yX<F;5Pi`NTy%A4$_Q#I!4c#^o0Sm)7
zHSKxebUfb34(3CX;tkE#8>ZbrD6|K=*)ZDL&jdblC*O{+twT4H8U3vai=eDC8I*A~
zA-~_1L9H>`D%Dq_(%QSD>QaxnF`?2Y^m;4E!fBDX6C!*!j<MI?=zCZCZVgOw(|(ih
zt=+y)X1cnzSLCFl>J3BHt%hn?54PFvw2d+yF9Ul^HdZxewTh6O8*=&i6~EiBRuV&+
zLf<tNUy9yMQXa^GnuIfBBP8_bhh^a&g^(I_WQYeDOD<SEhQXEdgi~e6K1)Jm>9f=B
z#TmJCj>++vV>Daj{PdbQ7sn0DgbI%9_zygmiK^6d!xz*FK20+=Vm?wbr1Wb}1@dnR
z@AFjjkswBFRxRzGttjcFd!lLWo@QC^l)XVt5jJZLn^wZsh8lv4{PTWr`htJlK+OeB
z#awI|3_?F4dXwmlh8nx`Ef6I#t(K}II*kGwboj?{tsw83s#z}|n-LY&kT)GY5@Mhk
zW=FGLuZ8BK7J8}N?RxG6K8F+&^rFZVxufrF5T%RA+wc;$j<jG(*etYgO@(mBlw2ZY
z2U0+58J4D-ZL_UnhqQH~lNUxm5vS~Nax%B!`ttg$OGhsHXQ(X;cns_6LfP|_&LzRw
z;FKHxWgn&?%cz{B!9K)1!~HvQ=SUi|JXnPEOU8?3#FV;PSX|HQW?93UYP24zKU^Z8
z5UPy&XqjO1rf!CnPq0EVicmjmejCnj-q){KoX;>eL!FU^I)nQ$jcLmK2h_DXr<AGM
zCKbiWy)S6WhWkHOIeLKm{_)`S;sL(qJk4>@Z5+)3BT86A5g8hT$dh6d3eds{rSSke
zk-nDbPvjbFa)QMC0ZX0n7~N12dtK?L=v_c@OSFqEM!AxB7O7sVQa4W-g~0n*<eu<T
z=Ha@7Fv}8Q*X!jTwHB^VN~?9AWN1{>*D8P8SN0C%=ZxDMyYqquHhllLC;>Xm*CrQE
z9H)MWz%CrvW#26&>R~pCHjLL73M8xG>KASty@>aMM#(P8?>US|m}Ifs`8#0A4=f(>
zpF(Q`t5e^G-{}(`hClLX1P6~(d~7!BJ{(6LaxsT<1dO?GP>hb)*o~N5iYR-9T@R0I
zj~n*(;o6<S9c9@!L?@NcEgCpWQ=SU4O+i0;22)Bhu;G_=Yy9%Iqwy#584tFy3CQg<
zmO6iw$!gywe5eh7*6K2pXWhS+u;I?>4K;wz!<NzM7)_(u0jED0>dTo{N7ENG;5hi}
z^!i=-(}(vT4HIeg{Ymlo-0P9E6BIbTb$S4|-7CNq=XZ^vJ~S{EJX4yjVY9KYPCl?S
z7sScjEEnjZq6|VNV2Zb*ETqWQNIi7s)1rsn2qrwpk%d^yG8iEeavCLFWN40eE5Ro;
z3z0Du8VM>t#NdKJuyB#AZFwj2g7j&a(y^rXw1Sr{H;TkQ>I8f#%odfV1gX513RU_<
z;j5p{lZ+2TSA@d_0SZ80T|dil;anQRFqjXR5C3r=B#-08PM$U0Oj#0W#wJt+=<z7x
z)3r77g?r?mmDAgs-sSnQcYBL|aXi7rMTB_HL<O;sF30{HU2^a`DYuBxh<Nkw@4<K2
ze{{Oo4ZkOtojC&(^Zxw47$HO{ovvTIk934lsoeV_;4d(sw)$3XAF2<<-(O$?DOMUF
zR|rH2w`94$>Il7%$1xsPYSn#c%H5V0q+KCZMG4qwglor`a<{(AuD5GeVOaDtFip2<
z>Md3Et#;7Tnz;9CEz^`i?AE5#YPDB19vuN`?BjMVe{fJH4nL7O)DE#i_|#B&`9yvk
z`Pi%3YQm3lS#Ybdh}}eld_zEap^*miE9L~Zbl+RNM=0uIjV*?m>qX1=m5p7hNKu#D
z-&Pg(;iCJgDg~dyV20Y{gCK9<g=#s9_!t+H=ZecTbEURJD;`hq&_294b}p)0!q44H
z+!T8Vn--0E(PKcpd|bX_3$oF?d{1eD$FLpC%c1A`kLWVWZer^u?3I{5Ufwi}!mrew
zk|~QDGJVC9xQyef9i_J_Ywy{_qTm`0-D?|IaJn_}XkhIsxYd%)T3b!ZGShXvv9D`T
zD_&Z%+7{$;B89sJHI+<Ou7gAPuL8<a>WSlVe&h2{GG;~2RuvQ^vL)FFD*xC?Yn4Av
z@BZu$Zi~bXkFU;$c%#CLRJFQXEC1@hLOBg`@$yh8DN&vc7*Yll_v6w(+`gDk;n(_F
sL0bH;)4Ouwe@Zd8P0s(?2mz1KQV4+r#ZWt{rYOq)0Uh~Y*gF&e0E}xe*#H0l

diff --git a/tests/test_import.py b/tests/test_import.py
index 8fd706f..9e870e8 100755
--- a/tests/test_import.py
+++ b/tests/test_import.py
@@ -33,17 +33,6 @@ class ImportTest(PatchewTestCase):
         a = '[Qemu-devel] [PATCH] quorum: Only compile when supported\n' * 2
         self.check_cli(["search"], stdout=a.strip())
 
-    def test_case_insensitive(self):
-        self.cli_import("0002-unusual-cased-tags.mbox.gz")
-        a, b = self.check_cli(["search", "-r", "-o", "subject,properties"])
-        ao = json.loads(a)[0]
-        self.assertEqual(["Fam Zheng", "famz@redhat.com"],
-                         ao["properties"]["reviewers"][0])
-        self.assertIn('Reviewed-By: Fam Zheng <famz@redhat.com>',
-                      ao["properties"]["tags"])
-        self.assertIn('tESTed-bY: Fam Zheng <famz@redhat.com>',
-                      ao["properties"]["tags"])
-
     def test_non_utf_8(self):
         self.cli_import("0005-non-utf-8.mbox.gz")
 
-- 
2.21.0


_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel
Re: [Patchew-devel] [PATCH 5/7] tests: remove case insensitive tags test
Posted by Fam Zheng 6 years, 9 months ago 

> On Apr 17, 2019, at 18:09, Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> I am not sure what this is testing, and it is the only user of properties search.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/data/0002-unusual-cased-tags.mbox.gz | Bin 2166 -> 0 bytes
> tests/test_import.py                       |  11 -----------
> 2 files changed, 11 deletions(-)
> delete mode 100644 tests/data/0002-unusual-cased-tags.mbox.gz
> 
> diff --git a/tests/data/0002-unusual-cased-tags.mbox.gz b/tests/data/0002-unusual-cased-tags.mbox.gz
> deleted file mode 100644
> index 3968ed24c891b6b9f07e4837421280f1efa70e87..0000000000000000000000000000000000000000
> GIT binary patch
> literal 0
> HcmV?d00001
> 
> literal 2166
> zcmV-+2#NO}iwFpRGICb{128Z!GA(s(b#rxLY%OD9b7f>LbYW+6E^T6OcmSnX`*Y$r
> z68<^<EBdysu3(9bZ44MsvX=)T$!#8N%sh5dDasFlH8GaQvIETR{qNVZc_w6PHj}Es
> zmfY&c*WI6_>C%Wj(Ub;cz-?fYgr^xzj}kZYLpoJ?I#%wePf;cyPQPbE-xUHX-+0JX
> zpHFNE_{3!~@DY5albi(fiAKcZdF)eh6!Ul-=TZv<RIqXEW>kQoS*osEs?lhwdK+8;
> z2~8&~%V+?C#sN*C3gAbK#u;IW{cOQAhmuzvdXwqu+VJ7F^gEz22FDXhMk${hzKplF
> z#P4tezYP%HL5S-QBPKGTF6S_uEKg(7ceBujgTJr!w-q2ZNXKAHKUB7d_uD}|RKc6W
> zWTr|05x7W#sO(Ky7J_p<=sUmy(9Kp`Yg?VRZW^Z5GE}Q$v@NUC>@>A@^Br9Ccpr>5
> z{3nkQVZ8;qWj9;4t^?89ng*4AcTj!dCHLJZ<RXL0y>06ccB9d<Iy(@mDtqYSb`*tw
> zR7|o2DrYk`0aI=3C|KD_(VNgjEiz>9f^|%yX<F;5Pi`NTy%A4$_Q#I!4c#^o0Sm)7
> zHSKxebUfb34(3CX;tkE#8>ZbrD6|K=*)ZDL&jdblC*O{+twT4H8U3vai=eDC8I*A~
> zA-~_1L9H>`D%Dq_(%QSD>QaxnF`?2Y^m;4E!fBDX6C!*!j<MI?=zCZCZVgOw(|(ih
> zt=+y)X1cnzSLCFl>J3BHt%hn?54PFvw2d+yF9Ul^HdZxewTh6O8*=&i6~EiBRuV&+
> zLf<tNUy9yMQXa^GnuIfBBP8_bhh^a&g^(I_WQYeDOD<SEhQXEdgi~e6K1)Jm>9f=B
> z#TmJCj>++vV>Daj{PdbQ7sn0DgbI%9_zygmiK^6d!xz*FK20+=Vm?wbr1Wb}1@dnR
> z@AFjjkswBFRxRzGttjcFd!lLWo@QC^l)XVt5jJZLn^wZsh8lv4{PTWr`htJlK+OeB
> z#awI|3_?F4dXwmlh8nx`Ef6I#t(K}II*kGwboj?{tsw83s#z}|n-LY&kT)GY5@Mhk
> zW=FGLuZ8BK7J8}N?RxG6K8F+&^rFZVxufrF5T%RA+wc;$j<jG(*etYgO@(mBlw2ZY
> z2U0+58J4D-ZL_UnhqQH~lNUxm5vS~Nax%B!`ttg$OGhsHXQ(X;cns_6LfP|_&LzRw
> z;FKHxWgn&?%cz{B!9K)1!~HvQ=SUi|JXnPEOU8?3#FV;PSX|HQW?93UYP24zKU^Z8
> z5UPy&XqjO1rf!CnPq0EVicmjmejCnj-q){KoX;>eL!FU^I)nQ$jcLmK2h_DXr<AGM
> zCKbiWy)S6WhWkHOIeLKm{_)`S;sL(qJk4>@Z5+)3BT86A5g8hT$dh6d3eds{rSSke
> zk-nDbPvjbFa)QMC0ZX0n7~N12dtK?L=v_c@OSFqEM!AxB7O7sVQa4W-g~0n*<eu<T
> z=Ha@7Fv}8Q*X!jTwHB^VN~?9AWN1{>*D8P8SN0C%=ZxDMyYqquHhllLC;>Xm*CrQE
> z9H)MWz%CrvW#26&>R~pCHjLL73M8xG>KASty@>aMM#(P8?>US|m}Ifs`8#0A4=f(>
> zpF(Q`t5e^G-{}(`hClLX1P6~(d~7!BJ{(6LaxsT<1dO?GP>hb)*o~N5iYR-9T@R0I
> zj~n*(;o6<S9c9@!L?@NcEgCpWQ=SU4O+i0;22)Bhu;G_=Yy9%Iqwy#584tFy3CQg<
> zmO6iw$!gywe5eh7*6K2pXWhS+u;I?>4K;wz!<NzM7)_(u0jED0>dTo{N7ENG;5hi}
> z^!i=-(}(vT4HIeg{Ymlo-0P9E6BIbTb$S4|-7CNq=XZ^vJ~S{EJX4yjVY9KYPCl?S
> z7sScjEEnjZq6|VNV2Zb*ETqWQNIi7s)1rsn2qrwpk%d^yG8iEeavCLFWN40eE5Ro;
> z3z0Du8VM>t#NdKJuyB#AZFwj2g7j&a(y^rXw1Sr{H;TkQ>I8f#%odfV1gX513RU_<
> z;j5p{lZ+2TSA@d_0SZ80T|dil;anQRFqjXR5C3r=B#-08PM$U0Oj#0W#wJt+=<z7x
> z)3r77g?r?mmDAgs-sSnQcYBL|aXi7rMTB_HL<O;sF30{HU2^a`DYuBxh<Nkw@4<K2
> ze{{Oo4ZkOtojC&(^Zxw47$HO{ovvTIk934lsoeV_;4d(sw)$3XAF2<<-(O$?DOMUF
> zR|rH2w`94$>Il7%$1xsPYSn#c%H5V0q+KCZMG4qwglor`a<{(AuD5GeVOaDtFip2<
> z>Md3Et#;7Tnz;9CEz^`i?AE5#YPDB19vuN`?BjMVe{fJH4nL7O)DE#i_|#B&`9yvk
> z`Pi%3YQm3lS#Ybdh}}eld_zEap^*miE9L~Zbl+RNM=0uIjV*?m>qX1=m5p7hNKu#D
> z-&Pg(;iCJgDg~dyV20Y{gCK9<g=#s9_!t+H=ZecTbEURJD;`hq&_294b}p)0!q44H
> z+!T8Vn--0E(PKcpd|bX_3$oF?d{1eD$FLpC%c1A`kLWVWZer^u?3I{5Ufwi}!mrew
> zk|~QDGJVC9xQyef9i_J_Ywy{_qTm`0-D?|IaJn_}XkhIsxYd%)T3b!ZGShXvv9D`T
> zD_&Z%+7{$;B89sJHI+<Ou7gAPuL8<a>WSlVe&h2{GG;~2RuvQ^vL)FFD*xC?Yn4Av
> z@BZu$Zi~bXkFU;$c%#CLRJFQXEC1@hLOBg`@$yh8DN&vc7*Yll_v6w(+`gDk;n(_F
> sL0bH;)4Ouwe@Zd8P0s(?2mz1KQV4+r#ZWt{rYOq)0Uh~Y*gF&e0E}xe*#H0l
> 
> diff --git a/tests/test_import.py b/tests/test_import.py
> index 8fd706f..9e870e8 100755
> --- a/tests/test_import.py
> +++ b/tests/test_import.py
> @@ -33,17 +33,6 @@ class ImportTest(PatchewTestCase):
>         a = '[Qemu-devel] [PATCH] quorum: Only compile when supported\n' * 2
>         self.check_cli(["search"], stdout=a.strip())
> 
> -    def test_case_insensitive(self):
> -        self.cli_import("0002-unusual-cased-tags.mbox.gz")
> -        a, b = self.check_cli(["search", "-r", "-o", "subject,properties"])
> -        ao = json.loads(a)[0]
> -        self.assertEqual(["Fam Zheng", "famz@redhat.com"],
> -                         ao["properties"]["reviewers"][0])
> -        self.assertIn('Reviewed-By: Fam Zheng <famz@redhat.com>',
> -                      ao["properties"]["tags"])
> -        self.assertIn('tESTed-bY: Fam Zheng <famz@redhat.com>',
> -                      ao["properties"]["tags"])
> -
>     def test_non_utf_8(self):
>         self.cli_import("0005-non-utf-8.mbox.gz")
> 
> -- 
> 2.21.0


IIRC the idea is that people don’t need to worry about typing “reviewed-by:” versus “Reviewed-by:” and “Reviewed-By:” for patchew to pick up.

Fam

> 
> 
> _______________________________________________
> Patchew-devel mailing list
> Patchew-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/patchew-devel



_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel
Re: [Patchew-devel] [PATCH 5/7] tests: remove case insensitive tags test
Posted by Paolo Bonzini 6 years, 9 months ago 
On 18/04/19 11:42, Fam Zheng wrote:
>> -        self.assertEqual(["Fam Zheng", "famz@redhat.com"],
>> -                         ao["properties"]["reviewers"][0])
>> -        self.assertIn('Reviewed-By: Fam Zheng <famz@redhat.com>',
>> -                      ao["properties"]["tags"])
>> -        self.assertIn('tESTed-bY: Fam Zheng <famz@redhat.com>',
>> -                      ao["properties"]["tags"])
>> -
>>     def test_non_utf_8(self):
>>         self.cli_import("0005-non-utf-8.mbox.gz")
>>
>> -- 
>> 2.21.0
> 
> IIRC the idea is that people don’t need to worry about typing “reviewed-by:” versus “Reviewed-by:” and “Reviewed-By:” for patchew to pick up.

Ah it tests the reviewers property.  Then I'll add the reviewers to the
REST API and use that in the test.

Paolo

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.