[Patchew-devel] [PATCH] testing: fix recursive checkout

Paolo Bonzini posted 1 patch 5 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/patchew next tags/patchew/20190113141329.19603-1-pbonzini@redhat.com
patchew-cli | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Patchew-devel] [PATCH] testing: fix recursive checkout
Posted by Paolo Bonzini 5 years, 2 months ago
git_clone_repo was erroneously passed True for "checkout" rather than
"recursive".

Fixes: fedc0d05686a61354b18dab781d3fef0cc66ccd7
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 patchew-cli | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/patchew-cli b/patchew-cli
index a66edb9..7e63e95 100755
--- a/patchew-cli
+++ b/patchew-cli
@@ -528,7 +528,7 @@ class TesterCommand(SubCommand):
         is_timeout = False
         try:
             clone = os.path.join(wd, "src")
-            git_clone_repo(clone, r["repo"], r["head"], logf, True)
+            git_clone_repo(clone, r["repo"], r["head"], logf, recursive=True)
             base = r["base"]
             if base:
                 subprocess.check_call(["git", "branch", "base", base],
-- 
2.20.1

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel
Re: [Patchew-devel] [PATCH] testing: fix recursive checkout
Posted by Philippe Mathieu-Daudé 5 years, 2 months ago
On 1/13/19 3:13 PM, Paolo Bonzini wrote:
> git_clone_repo was erroneously passed True for "checkout" rather than
> "recursive".
> 
> Fixes: fedc0d05686a61354b18dab781d3fef0cc66ccd7
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  patchew-cli | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/patchew-cli b/patchew-cli
> index a66edb9..7e63e95 100755
> --- a/patchew-cli
> +++ b/patchew-cli
> @@ -528,7 +528,7 @@ class TesterCommand(SubCommand):
>          is_timeout = False
>          try:
>              clone = os.path.join(wd, "src")
> -            git_clone_repo(clone, r["repo"], r["head"], logf, True)
> +            git_clone_repo(clone, r["repo"], r["head"], logf, recursive=True)
>              base = r["base"]
>              if base:
>                  subprocess.check_call(["git", "branch", "base", base],
> 

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel