[Patchew-devel] [PATCH 0/2] [PATCH] Apply PEP8 to tests and adjust apps and url

Caio Carrara posted 2 patches 1 week ago
Failed in applying to current master (apply log)
tests/patchewtest.py                     |  34 ++++----
tests/test_ansi2html.py                  |   1 +
tests/test_custom_tags.py                |   8 +-
tests/test_diff.py                       |   7 +-
tests/test_git.py                        |  11 ++-
tests/test_import.py                     |  11 +--
tests/test_mbox.py                       |  14 ++--
tests/test_message.py                    |   5 +-
tests/test_model.py                      |   5 +-
tests/test_project.py                    |   4 +-
tests/test_rest.py                       |  94 ++++++++++++++---------
tests/test_tags.py                       |   8 +-
tests/test_testing.py                    |  58 ++++++++------
www/apps.py                              |   2 -
www/urls.py                              |  40 +++++-----
17 files changed, 173 insertions(+), 129 deletions(-)
create mode 100644 tests/__init__.py

[Patchew-devel] [PATCH 0/2] [PATCH] Apply PEP8 to tests and adjust apps and url

Posted by Caio Carrara 1 week ago
Continuing the patches to apply PEP8 rules to all the project, this
series apply the rules to tests file and make some small adjustments to
url and views in www package.

Caio Carrara (2):
  Apply PEP8 to www apps and urls modules
  Apply PEP8 to tests modules

 tests/__init__.py                        |   0
 tests/data/0016-nested-multipart.mbox.gz | Bin 2122 -> 2118 bytes
 tests/patchewtest.py                     |  34 ++++----
 tests/test_ansi2html.py                  |   1 +
 tests/test_custom_tags.py                |   8 +-
 tests/test_diff.py                       |   7 +-
 tests/test_git.py                        |  11 ++-
 tests/test_import.py                     |  11 +--
 tests/test_mbox.py                       |  14 ++--
 tests/test_message.py                    |   5 +-
 tests/test_model.py                      |   5 +-
 tests/test_project.py                    |   4 +-
 tests/test_rest.py                       |  94 ++++++++++++++---------
 tests/test_tags.py                       |   8 +-
 tests/test_testing.py                    |  58 ++++++++------
 www/apps.py                              |   2 -
 www/urls.py                              |  40 +++++-----
 17 files changed, 173 insertions(+), 129 deletions(-)
 create mode 100644 tests/__init__.py

-- 
2.19.2

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel

Re: [Patchew-devel] [PATCH 0/2] [PATCH] Apply PEP8 to tests and adjust apps and url

Posted by Paolo Bonzini 1 week ago
On 28/11/18 22:56, Caio Carrara wrote:
> Continuing the patches to apply PEP8 rules to all the project, this
> series apply the rules to tests file and make some small adjustments to
> url and views in www package.

Would you be able to add a tox.ini file that can run pep8 tests and
"./manage.py test"?

I vaguely remember some issues when using "from .patchewtest".  However,
I cannot reproduce it, so I've pushed and we'll see if Travis complains...

Paolo

> Caio Carrara (2):
>   Apply PEP8 to www apps and urls modules
>   Apply PEP8 to tests modules
> 
>  tests/__init__.py                        |   0
>  tests/data/0016-nested-multipart.mbox.gz | Bin 2122 -> 2118 bytes
>  tests/patchewtest.py                     |  34 ++++----
>  tests/test_ansi2html.py                  |   1 +
>  tests/test_custom_tags.py                |   8 +-
>  tests/test_diff.py                       |   7 +-
>  tests/test_git.py                        |  11 ++-
>  tests/test_import.py                     |  11 +--
>  tests/test_mbox.py                       |  14 ++--
>  tests/test_message.py                    |   5 +-
>  tests/test_model.py                      |   5 +-
>  tests/test_project.py                    |   4 +-
>  tests/test_rest.py                       |  94 ++++++++++++++---------
>  tests/test_tags.py                       |   8 +-
>  tests/test_testing.py                    |  58 ++++++++------
>  www/apps.py                              |   2 -
>  www/urls.py                              |  40 +++++-----
>  17 files changed, 173 insertions(+), 129 deletions(-)
>  create mode 100644 tests/__init__.py
> 

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel

Re: [Patchew-devel] [PATCH 0/2] [PATCH] Apply PEP8 to tests and adjust apps and url

Posted by Caio Carrara 1 week ago
On Thu, Nov 29, 2018 at 10:40:59AM +0100, Paolo Bonzini wrote:
> On 28/11/18 22:56, Caio Carrara wrote:
> > Continuing the patches to apply PEP8 rules to all the project, this
> > series apply the rules to tests file and make some small adjustments to
> > url and views in www package.
> 
> Would you be able to add a tox.ini file that can run pep8 tests and
> "./manage.py test"?

Sure, I'm willing to add the proper lint checks to the CI execution.
However I think it's better to do it after we have most of the code
ready with the PEP8 rules, so we can have more confidence and less
annoyance on CI results. Does it make sense?

> 
> I vaguely remember some issues when using "from .patchewtest".  However,
> I cannot reproduce it, so I've pushed and we'll see if Travis complains...
> 
> Paolo
> 
> > Caio Carrara (2):
> >   Apply PEP8 to www apps and urls modules
> >   Apply PEP8 to tests modules
> > 
> >  tests/__init__.py                        |   0
> >  tests/data/0016-nested-multipart.mbox.gz | Bin 2122 -> 2118 bytes
> >  tests/patchewtest.py                     |  34 ++++----
> >  tests/test_ansi2html.py                  |   1 +
> >  tests/test_custom_tags.py                |   8 +-
> >  tests/test_diff.py                       |   7 +-
> >  tests/test_git.py                        |  11 ++-
> >  tests/test_import.py                     |  11 +--
> >  tests/test_mbox.py                       |  14 ++--
> >  tests/test_message.py                    |   5 +-
> >  tests/test_model.py                      |   5 +-
> >  tests/test_project.py                    |   4 +-
> >  tests/test_rest.py                       |  94 ++++++++++++++---------
> >  tests/test_tags.py                       |   8 +-
> >  tests/test_testing.py                    |  58 ++++++++------
> >  www/apps.py                              |   2 -
> >  www/urls.py                              |  40 +++++-----
> >  17 files changed, 173 insertions(+), 129 deletions(-)
> >  create mode 100644 tests/__init__.py
> > 
> 

-- 
Caio Carrara
Software Engineer, Virt Team - Red Hat
ccarrara@redhat.com

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel

Re: [Patchew-devel] [PATCH 0/2] [PATCH] Apply PEP8 to tests and adjust apps and url

Posted by Paolo Bonzini 1 week ago
On 29/11/18 14:26, Caio Carrara wrote:
> On Thu, Nov 29, 2018 at 10:40:59AM +0100, Paolo Bonzini wrote:
>> On 28/11/18 22:56, Caio Carrara wrote:
>>> Continuing the patches to apply PEP8 rules to all the project, this
>>> series apply the rules to tests file and make some small adjustments to
>>> url and views in www package.
>>
>> Would you be able to add a tox.ini file that can run pep8 tests and
>> "./manage.py test"?
> 
> Sure, I'm willing to add the proper lint checks to the CI execution.
> However I think it's better to do it after we have most of the code
> ready with the PEP8 rules, so we can have more confidence and less
> annoyance on CI results. Does it make sense?

Sure; however, tox is not used by CI. :)

Paolo

>>
>> I vaguely remember some issues when using "from .patchewtest".  However,
>> I cannot reproduce it, so I've pushed and we'll see if Travis complains...
>>
>> Paolo
>>
>>> Caio Carrara (2):
>>>   Apply PEP8 to www apps and urls modules
>>>   Apply PEP8 to tests modules
>>>
>>>  tests/__init__.py                        |   0
>>>  tests/data/0016-nested-multipart.mbox.gz | Bin 2122 -> 2118 bytes
>>>  tests/patchewtest.py                     |  34 ++++----
>>>  tests/test_ansi2html.py                  |   1 +
>>>  tests/test_custom_tags.py                |   8 +-
>>>  tests/test_diff.py                       |   7 +-
>>>  tests/test_git.py                        |  11 ++-
>>>  tests/test_import.py                     |  11 +--
>>>  tests/test_mbox.py                       |  14 ++--
>>>  tests/test_message.py                    |   5 +-
>>>  tests/test_model.py                      |   5 +-
>>>  tests/test_project.py                    |   4 +-
>>>  tests/test_rest.py                       |  94 ++++++++++++++---------
>>>  tests/test_tags.py                       |   8 +-
>>>  tests/test_testing.py                    |  58 ++++++++------
>>>  www/apps.py                              |   2 -
>>>  www/urls.py                              |  40 +++++-----
>>>  17 files changed, 173 insertions(+), 129 deletions(-)
>>>  create mode 100644 tests/__init__.py
>>>
>>
> 

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel