[Patchew-devel] [PATCH v2 00/11] More fixes on patchew.org

Fam Zheng posted 11 patches 5 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/patchew-ci tags/patchew/20180727035934.32555-1-famz@redhat.com
api/models.py                                 | 10 ++-
mods/testing.py                               | 23 ++++--
patchew-cli                                   |  2 +-
scripts/playbooks/deploy-testers.yml          |  8 +--
scripts/playbooks/templates/docker.service.j2 |  2 +
tests/patchewtest.py                          | 16 ++++-
tests/test_git.py                             |  5 --
tests/test_testing.py                         | 72 +++++++++----------
8 files changed, 79 insertions(+), 59 deletions(-)
[Patchew-devel] [PATCH v2 00/11] More fixes on patchew.org
Posted by Fam Zheng 5 years, 9 months ago
v2: Add test code for requirements. [Paolo]
    Use ResultUpdate event. [Paolo]

I have written these commits since last Sunday and all of them are running in
the current patchew.org deployment. The only thought is we should do a better
job on making use of next.patchew.org, which is always apparent but
nevertheless challenging: we don't have enough spare time and resources for a
full replication of the server, importers and testers.

On the other hand we've done a fairly good job with writing tests, and the only
real bug here is that we missed the regression caused by property to result
conversion for git, which leaded to a disjoint between git and testing: the
"event" connecting them was abandoned. The end-to-end
"importer->server->tester" case using patchew-cli should help catch such a bug
in the future.

Fam Zheng (11):
  testing: Avoid masking out outter iterator r
  cli: Default -N of tester command to -1
  deploy-testers: Allow deploy with normal user access
  models: Add ResultUpdate event
  testing: Fix git info for testing-get method
  testing: Reset testing upon git result update
  testing: Move do_apply to base class
  tests: Create repo automatically for projects
  tests: Fix "testing"
  docker: Unlimited restart of systemd service
  tests: Use requirements in test

 api/models.py                                 | 10 ++-
 mods/testing.py                               | 23 ++++--
 patchew-cli                                   |  2 +-
 scripts/playbooks/deploy-testers.yml          |  8 +--
 scripts/playbooks/templates/docker.service.j2 |  2 +
 tests/patchewtest.py                          | 16 ++++-
 tests/test_git.py                             |  5 --
 tests/test_testing.py                         | 72 +++++++++----------
 8 files changed, 79 insertions(+), 59 deletions(-)

-- 
2.17.1

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel
Re: [Patchew-devel] [PATCH v2 00/11] More fixes on patchew.org
Posted by Paolo Bonzini 5 years, 9 months ago
On 27/07/2018 05:59, Fam Zheng wrote:
> v2: Add test code for requirements. [Paolo]
>     Use ResultUpdate event. [Paolo]
> 
> I have written these commits since last Sunday and all of them are running in
> the current patchew.org deployment. The only thought is we should do a better
> job on making use of next.patchew.org, which is always apparent but
> nevertheless challenging: we don't have enough spare time and resources for a
> full replication of the server, importers and testers.
> 
> On the other hand we've done a fairly good job with writing tests, and the only
> real bug here is that we missed the regression caused by property to result
> conversion for git, which leaded to a disjoint between git and testing: the
> "event" connecting them was abandoned. The end-to-end
> "importer->server->tester" case using patchew-cli should help catch such a bug
> in the future.

Very good, thanks!  Please apply it. :)

Paolo

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel
Re: [Patchew-devel] [PATCH v2 00/11] More fixes on patchew.org
Posted by Fam Zheng 5 years, 9 months ago
On Fri, 07/27 08:48, Paolo Bonzini wrote:
> On 27/07/2018 05:59, Fam Zheng wrote:
> > v2: Add test code for requirements. [Paolo]
> >     Use ResultUpdate event. [Paolo]
> > 
> > I have written these commits since last Sunday and all of them are running in
> > the current patchew.org deployment. The only thought is we should do a better
> > job on making use of next.patchew.org, which is always apparent but
> > nevertheless challenging: we don't have enough spare time and resources for a
> > full replication of the server, importers and testers.
> > 
> > On the other hand we've done a fairly good job with writing tests, and the only
> > real bug here is that we missed the regression caused by property to result
> > conversion for git, which leaded to a disjoint between git and testing: the
> > "event" connecting them was abandoned. The end-to-end
> > "importer->server->tester" case using patchew-cli should help catch such a bug
> > in the future.
> 
> Very good, thanks!  Please apply it. :)

Pushed, thanks.

Fam

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel