[Patchew-devel] [PATCH] testing: remove dead code

Paolo Bonzini posted 1 patch 6 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/patchew-ci tags/patchew/20180323083511.27880-1-pbonzini@redhat.com
mods/testing.py       | 12 ------------
tests/test_testing.py |  2 --
2 files changed, 14 deletions(-)
[Patchew-devel] [PATCH] testing: remove dead code
Posted by Paolo Bonzini 6 years, 3 months ago
Fixes issue #72.
---
 mods/testing.py       | 12 ------------
 tests/test_testing.py |  2 --
 2 files changed, 14 deletions(-)

diff --git a/mods/testing.py b/mods/testing.py
index d6492aa..b05d9c9 100644
--- a/mods/testing.py
+++ b/mods/testing.py
@@ -59,10 +59,6 @@ class TestingModule(PatchewModule):
                         BooleanSchema("enabled", "Enabled",
                                       desc="Whether this test is enabled",
                                       default=True),
-                        StringSchema("users", "Users",
-                                     desc="List of allowed users to run this test"),
-                        StringSchema("testers", "Testers",
-                                     desc="List of allowed testers to run this test"),
                         StringSchema("requirements", "Requirements",
                                      desc="List of requirements of the test"),
                         IntegerSchema("timeout", "Timeout",
@@ -273,10 +269,6 @@ class TestingModule(PatchewModule):
                         })
         return ret
 
-    def _build_message_prop_url(message, prop):
-        return reverse("testing-get-prop",
-                       kwargs={"project_or_series": obj.message_id})
-
     def rest_results_hook(self, request, message, results):
         for pn, p in message.get_properties().items():
             if not pn.startswith("testing.report."):
@@ -414,10 +406,6 @@ class TestingGetView(APILoginRequiredView):
             if obj.get_property("testing.report." + tn):
                 done_tests.add(tn)
                 continue
-            if t.get("tester") and tester != t["tester"]:
-                continue
-            if t.get("user") and user.username != t["user"]:
-                continue
             # TODO: group?
             ok = True
             reqs = t.get("requirements", "")
diff --git a/tests/test_testing.py b/tests/test_testing.py
index 0897bbc..8a22e1f 100755
--- a/tests/test_testing.py
+++ b/tests/test_testing.py
@@ -21,8 +21,6 @@ def create_test(project, name):
     project.set_property(prefix + "enabled", True)
     project.set_property(prefix + "script", "#!/bin/bash\ntrue")
     project.set_property(prefix + "requirements", "")
-    project.set_property(prefix + "users", "")
-    project.set_property(prefix + "tester", "")
 
 class TestingTest(PatchewTestCase):
 
-- 
2.16.2

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel