git: remove /git-apply pattern

[Patchew-devel] [PATCH] git: remove /git-apply pattern

Posted by Paolo Bonzini 6 years, 1 month ago

This is not used anymore by the importer, so just drop it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 mods/git.py | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/mods/git.py b/mods/git.py
index cda42dd..5dd7131 100644
--- a/mods/git.py
+++ b/mods/git.py
@@ -233,15 +233,6 @@ class GitModule(PatchewModule):
             emit_event("ProjectGitUpdate", project=po.name)
         return cache_repo
 
-    def www_view_git_apply(self, request, series):
-        if not request.user.is_authenticated:
-            raise PermissionDenied
-        obj = Message.objects.find_series(series)
-        if not obj:
-            raise Http404("Not found: " + series)
-        self.on_series_update("GitApply", obj)
-        return HttpResponseRedirect(request.META.get('HTTP_REFERER'))
-
     def www_view_git_reset(self, request, series):
         if not request.user.is_authenticated:
             raise PermissionDenied
@@ -255,9 +246,6 @@ class GitModule(PatchewModule):
         return HttpResponseRedirect(request.META.get('HTTP_REFERER'))
 
     def www_url_hook(self, urlpatterns):
-        urlpatterns.append(url(r"^git-apply/(?P<series>.*)/",
-                               self.www_view_git_apply,
-                               name="git_apply"))
         urlpatterns.append(url(r"^git-reset/(?P<series>.*)/",
                                self.www_view_git_reset,
                                name="git_reset"))
-- 
2.14.3

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel

Re: [Patchew-devel] [PATCH] git: remove /git-apply pattern

Posted by Fam Zheng 6 years, 1 month ago

On Wed, 03/14 17:54, Paolo Bonzini wrote:
> This is not used anymore by the importer, so just drop it.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  mods/git.py | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/mods/git.py b/mods/git.py
> index cda42dd..5dd7131 100644
> --- a/mods/git.py
> +++ b/mods/git.py
> @@ -233,15 +233,6 @@ class GitModule(PatchewModule):
>              emit_event("ProjectGitUpdate", project=po.name)
>          return cache_repo
>  
> -    def www_view_git_apply(self, request, series):
> -        if not request.user.is_authenticated:
> -            raise PermissionDenied
> -        obj = Message.objects.find_series(series)
> -        if not obj:
> -            raise Http404("Not found: " + series)
> -        self.on_series_update("GitApply", obj)
> -        return HttpResponseRedirect(request.META.get('HTTP_REFERER'))
> -
>      def www_view_git_reset(self, request, series):
>          if not request.user.is_authenticated:
>              raise PermissionDenied
> @@ -255,9 +246,6 @@ class GitModule(PatchewModule):
>          return HttpResponseRedirect(request.META.get('HTTP_REFERER'))
>  
>      def www_url_hook(self, urlpatterns):
> -        urlpatterns.append(url(r"^git-apply/(?P<series>.*)/",
> -                               self.www_view_git_apply,
> -                               name="git_apply"))
>          urlpatterns.append(url(r"^git-reset/(?P<series>.*)/",
>                                 self.www_view_git_reset,
>                                 name="git_reset"))
> -- 
> 2.14.3
> 
> _______________________________________________
> Patchew-devel mailing list
> Patchew-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/patchew-devel

Applied, thanks.

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel