1. Patchew
  2. Patchew
  3. [Patchew-devel] [PATCH 0/5] deploy: improvements and fixes
  4. View patch

[Patchew-devel] [PATCH 2/5] deploy: install Python 3 pip

Paolo Bonzini posted 5 patches 6 years, 7 months ago
[Patchew-devel] [PATCH 2/5] deploy: install Python 3 pip
Posted by Paolo Bonzini 6 years, 7 months ago 
We do not really need the Python 2.x pip for anything.  In the end
Python 3.x pip is probably already there because Fedora has it as
a dependency of python3, but let's just be clean and install it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scripts/playbooks/tasks/docker-deploy.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/playbooks/tasks/docker-deploy.yml b/scripts/playbooks/tasks/docker-deploy.yml
index 21c8a8d..ec04306 100644
--- a/scripts/playbooks/tasks/docker-deploy.yml
+++ b/scripts/playbooks/tasks/docker-deploy.yml
@@ -1,10 +1,10 @@
 ---
-- name: Install pip
-  package:
-    name: python2-pip
 - name: Install Python 3
   package:
     name: python34
+- name: Install pip
+  package:
+    name: python3-pip
 - name: Install docker
   package:
     name: docker
-- 
2.14.3


_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel
Re: [Patchew-devel] [PATCH 2/5] deploy: install Python 3 pip
Posted by Fam Zheng 6 years, 7 months ago 
On Tue, 03/13 18:45, Paolo Bonzini wrote:
> We do not really need the Python 2.x pip for anything.  In the end
> Python 3.x pip is probably already there because Fedora has it as
> a dependency of python3, but let's just be clean and install it.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  scripts/playbooks/tasks/docker-deploy.yml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/playbooks/tasks/docker-deploy.yml b/scripts/playbooks/tasks/docker-deploy.yml
> index 21c8a8d..ec04306 100644
> --- a/scripts/playbooks/tasks/docker-deploy.yml
> +++ b/scripts/playbooks/tasks/docker-deploy.yml
> @@ -1,10 +1,10 @@
>  ---
> -- name: Install pip
> -  package:
> -    name: python2-pip
>  - name: Install Python 3
>    package:
>      name: python34
> +- name: Install pip
> +  package:
> +    name: python3-pip
>  - name: Install docker
>    package:
>      name: docker
> -- 
> 2.14.3
> 

I've reverted this one. It breaks deploying to RHEL 7.

Fam

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel
Re: [Patchew-devel] [PATCH 2/5] deploy: install Python 3 pip
Posted by Paolo Bonzini 6 years, 7 months ago 
On 16/03/2018 03:52, Fam Zheng wrote:
> On Tue, 03/13 18:45, Paolo Bonzini wrote:
>> We do not really need the Python 2.x pip for anything.  In the end
>> Python 3.x pip is probably already there because Fedora has it as
>> a dependency of python3, but let's just be clean and install it.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  scripts/playbooks/tasks/docker-deploy.yml | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/scripts/playbooks/tasks/docker-deploy.yml b/scripts/playbooks/tasks/docker-deploy.yml
>> index 21c8a8d..ec04306 100644
>> --- a/scripts/playbooks/tasks/docker-deploy.yml
>> +++ b/scripts/playbooks/tasks/docker-deploy.yml
>> @@ -1,10 +1,10 @@
>>  ---
>> -- name: Install pip
>> -  package:
>> -    name: python2-pip
>>  - name: Install Python 3
>>    package:
>>      name: python34
>> +- name: Install pip
>> +  package:
>> +    name: python3-pip
>>  - name: Install docker
>>    package:
>>      name: docker
>> -- 
>> 2.14.3
>>
> 
> I've reverted this one. It breaks deploying to RHEL 7.

Would the right fix be simply to remove the task, and not install either
python2-pip or python3-pip?

Paolo

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel
Re: [Patchew-devel] [PATCH 2/5] deploy: install Python 3 pip
Posted by Fam Zheng 6 years, 7 months ago 
On Fri, 03/16 17:44, Paolo Bonzini wrote:
> On 16/03/2018 03:52, Fam Zheng wrote:
> > On Tue, 03/13 18:45, Paolo Bonzini wrote:
> >> We do not really need the Python 2.x pip for anything.  In the end
> >> Python 3.x pip is probably already there because Fedora has it as
> >> a dependency of python3, but let's just be clean and install it.
> >>
> >> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >> ---
> >>  scripts/playbooks/tasks/docker-deploy.yml | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/scripts/playbooks/tasks/docker-deploy.yml b/scripts/playbooks/tasks/docker-deploy.yml
> >> index 21c8a8d..ec04306 100644
> >> --- a/scripts/playbooks/tasks/docker-deploy.yml
> >> +++ b/scripts/playbooks/tasks/docker-deploy.yml
> >> @@ -1,10 +1,10 @@
> >>  ---
> >> -- name: Install pip
> >> -  package:
> >> -    name: python2-pip
> >>  - name: Install Python 3
> >>    package:
> >>      name: python34
> >> +- name: Install pip
> >> +  package:
> >> +    name: python3-pip
> >>  - name: Install docker
> >>    package:
> >>      name: docker
> >> -- 
> >> 2.14.3
> >>
> > 
> > I've reverted this one. It breaks deploying to RHEL 7.
> 
> Would the right fix be simply to remove the task, and not install either
> python2-pip or python3-pip?

Better to use a fallback method. Will send a patch.

Fam

_______________________________________________
Patchew-devel mailing list
Patchew-devel@redhat.com
https://www.redhat.com/mailman/listinfo/patchew-devel

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.