[v1] selftests: mptcp: add csum mib check for mptcp_connect

[PATCH mptcp-next] selftests: mptcp: add csum mib check for mptcp_connect

Geliang Tang posted 1 patch 2 years, 2 months ago

Diff against v2
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/fdd9c6ef7ba7c360832acd349927871fbbee495b.1644720920.git.geliang.tang@suse.com

Maintainers: Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>, Matthieu Baerts <matthieu.baerts@tessares.net>, Mat Martineau <mathew.j.martineau@linux.intel.com>, "David S. Miller" <davem@davemloft.net>, Geliang Tang <geliangtang@gmail.com>

There is a newer version of this series

tools/testing/selftests/net/mptcp/mptcp_connect.sh | 14 ++++++++++++++
1 file changed, 14 insertions(+)

Expand all Fold all

[PATCH mptcp-next] selftests: mptcp: add csum mib check for mptcp_connect

Posted by Geliang Tang 2 years, 2 months ago

This patch added the data checksum error mib counter check for the
script mptcp_connect.sh when the data checksum is enabled.

The output looks like this:

ns1 MPTCP -> ns2 (dead:beef:2::1:10009) MPTCP   (duration    81ms) [ FAIL ]
client got 1 data checksum error[s]
ns1 MPTCP -> ns2 (10.0.2.1:10008      ) MPTCP   (duration    64ms) [ FAIL ]
server got 1 data checksum error[s]

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/255
Fixes: 94d66ba1d8e48 ("selftests: mptcp: enable checksum in mptcp_connect.sh")
Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 tools/testing/selftests/net/mptcp/mptcp_connect.sh | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
index cb5809b89081..4332debc9967 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
@@ -524,6 +524,20 @@ do_transfer()
 		fi
 	fi
 
+	if $checksum; then
+		local csum_err_s=$(get_mib_counter "${listener_ns}" "MPTcpExtDataCsumErr")
+		local csum_err_c=$(get_mib_counter "${connector_ns}" "MPTcpExtDataCsumErr")
+
+		if [ $csum_err_s -gt 0 ]; then
+			printf "[ FAIL ]\nserver got $csum_err_s data checksum error[s]"
+			rets=1
+		fi
+		if [ $csum_err_c -gt 0 ]; then
+			printf "[ FAIL ]\nclient got $csum_err_c data checksum error[s]"
+			retc=1
+		fi
+	fi
+
 	if [ $retc -eq 0 ] && [ $rets -eq 0 ]; then
 		printf "[ OK ]"
 	fi
-- 
2.34.1