[PATCH mptcp-next 0/2] TLS disconnect support

Geliang Tang posted 2 patches 1 day, 13 hours ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1791967771.git.tanggeliang@kylinos.cn
include/net/tls.h                 |  12 +++-
net/tls/tls_main.c                | 112 ++++++++++++++++++++++++++----
tools/testing/selftests/net/tls.c |  57 ++++++++++++++-
3 files changed, 163 insertions(+), 18 deletions(-)
[PATCH mptcp-next 0/2] TLS disconnect support
Posted by Geliang Tang 1 day, 13 hours ago
From: Geliang Tang <tanggeliang@kylinos.cn>

To verify the correctness of MPTCP KTLS implementation, I added TLS test
support to MPTCP selftests mptcp_connect.c. The test results showed that
the disconnect test group failed with error code EOPNOTSUPP, so I added
this series to support TLS disconnect.

Patch 1 implements tls_disconnect() to support disconnect operation for
TLS sockets via connect(AF_UNSPEC).

Patch 2 updates selftests to verify the full disconnect/reconnect cycle,
including data transfer verification before and after disconnect.

Geliang Tang (2):
  tls: implement tls_disconnect
  selftests: tls: update disconnect tests

 include/net/tls.h                 |  12 +++-
 net/tls/tls_main.c                | 112 ++++++++++++++++++++++++++----
 tools/testing/selftests/net/tls.c |  57 ++++++++++++++-
 3 files changed, 163 insertions(+), 18 deletions(-)

-- 
2.55.0
Re: [PATCH mptcp-next 0/2] TLS disconnect support
Posted by Matthieu Baerts 1 day, 9 hours ago
Hi Geliang,

On 14/10/2026 10:59, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> To verify the correctness of MPTCP KTLS implementation, I added TLS test
> support to MPTCP selftests mptcp_connect.c. The test results showed that
> the disconnect test group failed with error code EOPNOTSUPP, so I added
> this series to support TLS disconnect.

I guess that's more a question for the KTLS maintainers, but my feeling
is that the disconnect is not supported on purpose because that's
probably not used in production, and source of many errors: see all the
bugs found around that for TCP and MPTCP (and others).

In fact, I just did a git blame, and found this: 5071a1e606b3 ("net:
tls: explicitly disallow disconnect").

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-next 0/2] TLS disconnect support
Posted by MPTCP CI 1 day, 12 hours ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Success! ✅
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Success! ✅
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Perf: Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/38541308008

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/cab552cd4a4d
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1185404


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)