[PATCH mptcp-next v4 0/5] implement psock_update_sk_prot

Geliang Tang posted 5 patches 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1787554581.git.tanggeliang@kylinos.cn
net/mptcp/bpf.c                               | 106 ++++++++++++++++++
net/mptcp/protocol.c                          |  73 +++++++++++-
net/mptcp/protocol.h                          |   9 ++
.../testing/selftests/bpf/prog_tests/mptcp.c  |  42 ++++---
.../selftests/net/mptcp/mptcp_connect.c       |   5 +-
5 files changed, 212 insertions(+), 23 deletions(-)
[PATCH mptcp-next v4 0/5] implement psock_update_sk_prot
Posted by Geliang Tang 1 month ago
From: Geliang Tang <tanggeliang@kylinos.cn>

v4:
 - Address Mat's comments: implement .read_skb to make the selftests run.
 - Move mptcp_bpf_update_proto() from protocol.c to bpf.c.
 - Include the "implement .splice_eof" patches in this series, as they
   both modify mptcp_prot, mptcp_stream_ops and mptcp_v6_stream_ops.

v3:
 - Address the comments by ai review.
   - use WRITE_ONCE to set sk->sk_write_space.
   - update the selftest, set a new key for client socket.
 - Fix line length warnings.
 - https://patchwork.kernel.org/project/mptcp/cover/cover.1773826662.git.tanggeliang@kylinos.cn/

RESEND:
 - rebased.
 - to trigger ai review.

v2:
 - Include mptcp_bpf_update_proto within CONFIG_BPF_SYSCALL to fix the
compilation errors reported by the kernel test robot.
 - Add checks for IS_ENABLED(CONFIG_MPTCP_IPV6).

Implement psock_update_sk_prot, for basic MPTCP BPF SOCKMAP support.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/521

Geliang Tang (5):
  mptcp: implement .splice_eof
  selftests: mptcp: connect: trigger splice_eof
  mptcp: implement read_skb for sockmap stream verdict
  mptcp: implement psock_update_sk_prot
  selftests/bpf: Update sockmap tests for MPTCP

 net/mptcp/bpf.c                               | 106 ++++++++++++++++++
 net/mptcp/protocol.c                          |  73 +++++++++++-
 net/mptcp/protocol.h                          |   9 ++
 .../testing/selftests/bpf/prog_tests/mptcp.c  |  42 ++++---
 .../selftests/net/mptcp/mptcp_connect.c       |   5 +-
 5 files changed, 212 insertions(+), 23 deletions(-)

-- 
2.53.0
Re: [PATCH mptcp-next v4 0/5] implement psock_update_sk_prot
Posted by MPTCP CI 1 month ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Success! ✅
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Success! ✅
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/32701957766

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/e4b106e7b0f4
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1150669


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)