[PATCH mptcp-next 0/6] Fix socket options used by NVMe over MPTCP

Geliang Tang posted 6 patches 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1784985085.git.tanggeliang@kylinos.cn
There is a newer version of this series
net/mptcp/protocol.c                          |   2 +
net/mptcp/sockopt.c                           |  28 ++++-
.../selftests/net/mptcp/mptcp_sockopt.c       | 116 ++++++++++++++++++
3 files changed, 141 insertions(+), 5 deletions(-)
[PATCH mptcp-next 0/6] Fix socket options used by NVMe over MPTCP
Posted by Geliang Tang 1 month ago
From: Geliang Tang <tanggeliang@kylinos.cn>

NVMe over MPTCP relies on SO_LINGER, SO_PRIORITY, SO_REUSEADDR, TCP_SYNCNT,
TCP_NODELAY, IP_TOS, and SO_BINDTODEVICE. This series contains fixes to make
all of them work correctly. Patch 4 is a cleanup needed by patch 5. Patch 6
adds a selftest to cover these options.

Geliang Tang (6):
  mptcp: copy the subflow's rcv_tos to the msk on accept
  mptcp: don't reset dst when setting default 0 tos
  mptcp: inherit sk_reuse on subflow creation
  mptcp: handle TCP_MAXSEG getsockopt in common case
  mptcp: add TCP_SYNCNT setsockopt/getsockopt
  selftests: mptcp: sockopt: cover LINGER REUSEADDR PRIORITY NODELAY
    SYNCNT

 net/mptcp/protocol.c                          |   2 +
 net/mptcp/sockopt.c                           |  28 ++++-
 .../selftests/net/mptcp/mptcp_sockopt.c       | 116 ++++++++++++++++++
 3 files changed, 141 insertions(+), 5 deletions(-)

-- 
2.53.0
Re: [PATCH mptcp-next 0/6] Fix socket options used by NVMe over MPTCP
Posted by MPTCP CI 1 month ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Unstable: 1 failed test(s): selftest_simult_flows ⚠️ 
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Success! ✅
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/30160012728

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/bf15e67a2e42
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1134397


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)