From: Geliang Tang <tanggeliang@kylinos.cn>

v6:
 - patch 2: now explicitly removes userspace pm addresses using
   userspace_pm_rm_addr, instead of merely updating dump_addr expectations.
 - patch 3: dropped duplicate "sleep 0.5".
 - The pre-existing issue Sashiko mentioned in v5, "it's not safe to
   decrement sk->sk_omem_alloc synchronously while deferring the actual
   memory free via kfree_rcu_mightsleep(match)", will be addressed in a
   separate patch.

v5:
 - rebased.
 - add Matt's reviewed tags.
 - add a RM_ADDR from the server to the client as Sashiko suggested.
 - mptcpd tests (make check) are still OK after this modification.
 - Link: https://patchwork.kernel.org/project/mptcp/cover/cover.1782457962.git.tanggeliang@kylinos.cn/

v4:
 - rebased.
 - Link: https://patchwork.kernel.org/project/mptcp/cover/cover.1776466833.git.tanggeliang@kylinos.cn/

v3:
 - update userspace selftests.
 - Link: https://patchwork.kernel.org/project/mptcp/cover/cover.1744787273.git.tanggeliang@kylinos.cn/

v2:
 - squash patch 1 into patch 2 as Mat suggested.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/403

Geliang Tang (3):
  mptcp: pm: userspace: drop delete_local_addr helper
  selftests: mptcp: join: explicitly remove userspace pm addresses
  selftests: mptcp: userspace: send RM_ADDR between server and client

 net/mptcp/pm_userspace.c                      | 35 ++-----------------
 .../testing/selftests/net/mptcp/mptcp_join.sh |  4 ++-
 .../selftests/net/mptcp/userspace_pm.sh       | 14 ++++++++
 3 files changed, 19 insertions(+), 34 deletions(-)

-- 
2.53.0

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Unstable: 1 failed test(s): selftest_simult_flows ⚠️ 
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Success! ✅
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/28270421412

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/0e0044b5cd3c
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1117313


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)