[PATCH mptcp-next v4 0/2] implement .splice_eof

Geliang Tang posted 2 patches 2 days, 13 hours ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1780968872.git.tanggeliang@kylinos.cn
net/mptcp/protocol.c                          | 31 +++++++++++++++++++
.../selftests/net/mptcp/mptcp_connect.c       |  5 ++-
2 files changed, 35 insertions(+), 1 deletion(-)
[PATCH mptcp-next v4 0/2] implement .splice_eof
Posted by Geliang Tang 2 days, 13 hours ago
From: Geliang Tang <tanggeliang@kylinos.cn>

v4:
 - patch 2, handle cases where sendfile returns 0 or a value
   larger than the remaining count. In such cases, break out
   of the loop to prevent unsigned integer underflow and
   potential infinite loop.

v3:
 - drop do_tcp_splice_eof helper.
 - invoke __mptcp_push_pending in mptcp_splice_eof.
 - use lock_sock_nested in mptcp_splice_eof.
 - set splice_eof in mptcp_v6_stream_ops too.
 - Link: https://patchwork.kernel.org/project/mptcp/cover/cover.1780909894.git.tanggeliang@kylinos.cn/

RESEND:
 - to trigger ai review.
 - Link: https://patchwork.kernel.org/project/mptcp/cover/cover.1773740361.git.tanggeliang@kylinos.cn/

v2:
 - add sk_state check in mptcp_splice_eof. (Matt)
 - call mptcp_rps_record_subflows in mptcp_splice_eof. (Matt)
 - update commit logs.

This set implements .splice_eof for MPTCP and tests it.

v1:
 - Link: https://patchwork.kernel.org/project/mptcp/cover/cover.1770023932.git.tanggeliang@kylinos.cn/

Geliang Tang (2):
  mptcp: implement .splice_eof
  selftests: mptcp: connect: trigger splice_eof

 net/mptcp/protocol.c                          | 31 +++++++++++++++++++
 .../selftests/net/mptcp/mptcp_connect.c       |  5 ++-
 2 files changed, 35 insertions(+), 1 deletion(-)

-- 
2.43.0
Re: [PATCH mptcp-next v4 0/2] implement .splice_eof
Posted by MPTCP CI 2 days, 11 hours ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Success! ✅
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Success! ✅
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/27178965576

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/4b0197466c9f
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1108212


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)