From: Geliang Tang <tanggeliang@kylinos.cn>

While developing MPTCP splice_read, Paolo suggested adding a new helper,
tcp_recv_should_stop, to reduce code duplication. This patchset implements
it for use in both MPTCP and TLS.

Based on an earlier version and following Mat's feedback, the sock_error()
check has been moved out of tcp_recv_should_stop(). Also use this helper in
TLS and TCP-BPF.

Geliang Tang (3):
  tcp: add recv_should_stop helper
  mptcp: use recv_should_stop helper
  tls: use recv_should_stop helper

 include/net/tcp.h    | 23 ++++++++++++++++++
 net/ipv4/tcp.c       | 58 +++++++++-----------------------------------
 net/ipv4/tcp_bpf.c   | 22 ++++-------------
 net/mptcp/protocol.c | 52 +++++++++------------------------------
 net/tls/tls_sw.c     | 18 +++++---------
 5 files changed, 56 insertions(+), 117 deletions(-)

-- 
2.51.0

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Success! ✅
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Success! ✅
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/20188543480

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/1b24ef0e3abf
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1032825


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)