[RFC mptcp-next 00/10] MPTCP KTLS support

Geliang Tang posted 10 patches 1 week, 2 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1763438045.git.tanggeliang@kylinos.cn
There is a newer version of this series
include/net/mptcp.h                           |  34 ++++++
net/mptcp/protocol.c                          |  61 ++++++++--
net/mptcp/sockopt.c                           |  18 ++-
net/tls/tls_main.c                            |   7 +-
net/tls/tls_strp.c                            |  20 ++-
tools/testing/selftests/net/mptcp/config      |   1 +
.../selftests/net/mptcp/mptcp_connect.c       |  42 ++++---
.../selftests/net/mptcp/mptcp_sockopt.c       | 114 +++++++++++++++---
.../selftests/net/mptcp/mptcp_sockopt.sh      |  47 ++++++++
9 files changed, 297 insertions(+), 47 deletions(-)
[RFC mptcp-next 00/10] MPTCP KTLS support
Posted by Geliang Tang 1 week, 2 days ago
From: Geliang Tang <tanggeliang@kylinos.cn>

This series adds KTLS support for MPTCP. Since the ULP of msk is not being
used, ULP KTLS can be directly configured onto msk without affecting its
communication.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/480

Depends on: implement mptcp read_sock, v13
Based-on: <cover.1761198660.git.geliang@kernel.org>

Geliang Tang (10):
  selftests: mptcp: sockopt: add protocol arguments
  selftests: mptcp: sockopt: skip mptcp getsockopt for tcp tests
  selftests: mptcp: sockopt: add TLS argument support
  selftests: mptcp: sockopt: implement TCP TLS tests
  tls: add MPTCP protocol support
  mptcp: enable TLS socket options
  selftests: mptcp: connect: enhance TCP ULP testing
  selftests: mptcp: connect: skip TLS in disconnect tests
  selftests: mptcp: connect: fix uninitialized variable warning
  selftests: mptcp: sockopt: add MPTCP TLS test cases

 include/net/mptcp.h                           |  34 ++++++
 net/mptcp/protocol.c                          |  61 ++++++++--
 net/mptcp/sockopt.c                           |  18 ++-
 net/tls/tls_main.c                            |   7 +-
 net/tls/tls_strp.c                            |  20 ++-
 tools/testing/selftests/net/mptcp/config      |   1 +
 .../selftests/net/mptcp/mptcp_connect.c       |  42 ++++---
 .../selftests/net/mptcp/mptcp_sockopt.c       | 114 +++++++++++++++---
 .../selftests/net/mptcp/mptcp_sockopt.sh      |  47 ++++++++
 9 files changed, 297 insertions(+), 47 deletions(-)

-- 
2.51.0
Re: [RFC mptcp-next 00/10] MPTCP KTLS support
Posted by MPTCP CI 1 week, 2 days ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Unstable: 1 failed test(s): packetdrill_dss 🔴
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Unstable: 1 failed test(s): packetdrill_dss 🔴
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/19453856409

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/b37b703d4e0a
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1024635


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Re: [RFC mptcp-next 00/10] MPTCP KTLS support
Posted by MPTCP CI 1 week, 2 days ago
Hi Geliang,

Thank you for your modifications, that's great!

But sadly, our CI spotted some issues with it when trying to build it.

You can find more details there:

  https://github.com/multipath-tcp/mptcp_net-next/actions/runs/19453856367

Status: failure
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/b37b703d4e0a
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1024635

Feel free to reply to this email if you cannot access logs, if you need
some support to fix the error, if this doesn't seem to be caused by your
modifications or if the error is a false positive one.

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)