[PATCH mptcp-net 0/3] mptcp: a few random fixes

Paolo Abeni posted 3 patches 1 week, 6 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1763075056.git.pabeni@redhat.com
net/mptcp/protocol.c | 37 +++++++++++++++++++++++++++++--------
net/mptcp/subflow.c  |  3 ++-
2 files changed, 31 insertions(+), 9 deletions(-)
[PATCH mptcp-net 0/3] mptcp: a few random fixes
Posted by Paolo Abeni 1 week, 6 days ago
The first patch fixes selftest failures in CONFIG_PREEMPT build.
The second patch addresses a recently filed issue, 2nd one is due to
code inspection while investigating the mentioned issue.

v2 -> v3:
  - new patch 1/3
  - check OoO queue in mptcp_try_fallback

v1 -> v2:
  - fix pktdrill failures due to missing rcv_wnd_sent initialization

Paolo Abeni (3):
  mptcp: fix premature close in case of fallback
  mptcp: do not fallback when OoO is present
  mptcp: do not drop partial packets.

 net/mptcp/protocol.c | 37 +++++++++++++++++++++++++++++--------
 net/mptcp/subflow.c  |  3 ++-
 2 files changed, 31 insertions(+), 9 deletions(-)

-- 
2.51.1
Re: [PATCH mptcp-net 0/3] mptcp: a few random fixes
Posted by Matthieu Baerts 1 week, 5 days ago
Hi Paolo,

On 14/11/2025 00:05, Paolo Abeni wrote:
> The first patch fixes selftest failures in CONFIG_PREEMPT build.
> The second patch addresses a recently filed issue, 2nd one is due to
> code inspection while investigating the mentioned issue.

Thank you again! Now in our tree (fixes for -net):

New patches for t/upstream-net and t/upstream:
- f00f2972e67b: mptcp: fix premature close in case of fallback
- 8e46f6ba1eea: mptcp: do not fallback when OoO is present
- 1d2ce718811a: mptcp: do not drop partial packets
- Results: 7b864be7a6e5..d3c1552df7fb (export-net)
- 42c9778f2eef: conflict in t/mptcp-borrow-forward-memory-from-subflow
- Results: 2636e284e552..13d7de45372c (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/2e032d2fe4e08ca8caac051eb86c063a29cf6dca/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/a7420f3fafe4ac3877b5bafdea23b2c13d3e2d61/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-net 0/3] mptcp: a few random fixes
Posted by Matthieu Baerts 1 week, 5 days ago
Hi Paolo,

On 14/11/2025 00:05, Paolo Abeni wrote:
> The first patch fixes selftest failures in CONFIG_PREEMPT build.
> The second patch addresses a recently filed issue, 2nd one is due to
> code inspection while investigating the mentioned issue.

Thank you for the new version!

It looks good to me:

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-net 0/3] mptcp: a few random fixes
Posted by MPTCP CI 1 week, 6 days ago
Hi Paolo,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Critical: 85 Call Trace(s) - Critical: Global Timeout ❌
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Success! ✅
- KVM Validation: debug (only selftest_mptcp_join): Unstable: 1 failed test(s): selftest_mptcp_join 🔴
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Unstable: 1 failed test(s): bpftest_test_progs-cpuv4_mptcp 🔴
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/19349079984

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/88e88d30abed
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1023207


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)