[RFC mptcp-next 0/6] NVME over MPTCP

Geliang Tang posted 6 patches 2 weeks, 6 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1762485513.git.tanggeliang@kylinos.cn
There is a newer version of this series
drivers/nvme/host/tcp.c                       | 27 ++++++++-
drivers/nvme/target/configfs.c                |  1 +
drivers/nvme/target/tcp.c                     | 54 ++++++++++++++++--
include/linux/nvme.h                          |  1 +
include/net/mptcp.h                           |  8 +++
net/mptcp/protocol.c                          | 33 +++++++++++
tools/testing/selftests/net/mptcp/config      |  7 +++
.../testing/selftests/net/mptcp/mptcp_nvme.sh | 57 +++++++++++++++++++
8 files changed, 180 insertions(+), 8 deletions(-)
create mode 100755 tools/testing/selftests/net/mptcp/mptcp_nvme.sh
[RFC mptcp-next 0/6] NVME over MPTCP
Posted by Geliang Tang 2 weeks, 6 days ago
From: Geliang Tang <tanggeliang@kylinos.cn>

This series (previously named "MPTCP support to 'NVME over TCP'") had three
RFC versions sent to Hannes in May, with subsequent revisions based on his
input. Following that, I initiated the process of upstreaming the dependent
"implement mptcp read_sock" series to the main MPTCP repository, which has
now largely taken shape.

Currently, the biggest problem I'm facing is in Patch 6, where I'm unsure how
to handle MSG_DONTWAIT. That's why I've sent this RFC version to get your
opinions.

Based-on: <cover.1761198660.git.geliang@kernel.org>

Geliang Tang (6):
  mptcp: add sock_set_nodelay
  nvmet-tcp: add mptcp support
  mptcp: add sock_set_reuseaddr
  nvme-tcp: add mptcp support
  selftests: mptcp: add NVMe-over-MPTCP test
  nvmet-tcp: clear MSG_DONTWAIT for MPTCP (TODO: HELP WANTED)

 drivers/nvme/host/tcp.c                       | 27 ++++++++-
 drivers/nvme/target/configfs.c                |  1 +
 drivers/nvme/target/tcp.c                     | 54 ++++++++++++++++--
 include/linux/nvme.h                          |  1 +
 include/net/mptcp.h                           |  8 +++
 net/mptcp/protocol.c                          | 33 +++++++++++
 tools/testing/selftests/net/mptcp/config      |  7 +++
 .../testing/selftests/net/mptcp/mptcp_nvme.sh | 57 +++++++++++++++++++
 8 files changed, 180 insertions(+), 8 deletions(-)
 create mode 100755 tools/testing/selftests/net/mptcp/mptcp_nvme.sh

-- 
2.43.0
Re: [RFC mptcp-next 0/6] NVME over MPTCP
Posted by MPTCP CI 2 weeks, 6 days ago
Hi Geliang,

Thank you for your modifications, that's great!

But sadly, our CI spotted some issues with it when trying to build it.

You can find more details there:

  https://github.com/multipath-tcp/mptcp_net-next/actions/runs/19157587244

Status: failure
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/4d1bb0e3c51a
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1020727

Feel free to reply to this email if you cannot access logs, if you need
some support to fix the error, if this doesn't seem to be caused by your
modifications or if the error is a false positive one.

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Re: [RFC mptcp-next 0/6] NVME over MPTCP
Posted by MPTCP CI 2 weeks, 6 days ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Unstable: 1 failed test(s): packetdrill_dss 🔴
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Unstable: 1 failed test(s): packetdrill_dss 🔴
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/19157587224

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/4d1bb0e3c51a
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1020727


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)