[PATCH mptcp-next 0/4] mptcp: autotune related improvement

Paolo Abeni posted 4 patches 3 weeks, 5 days ago
Failed in applying to current master (apply log)
There is a newer version of this series
net/mptcp/options.c  |  31 ++++++++
net/mptcp/protocol.c | 177 ++++++++++++++++++++++++++-----------------
net/mptcp/protocol.h |  15 +++-
net/mptcp/subflow.c  |   2 -
4 files changed, 150 insertions(+), 75 deletions(-)
[PATCH mptcp-next 0/4] mptcp: autotune related improvement
Posted by Paolo Abeni 3 weeks, 5 days ago
This series collects a few follow-up for the backlog refactor, with some
of them posing as fixes just to confuse the enemy (or feel the season
mood)

Targeting net-next as the issues addressed are very old, the change
is quite invasive and, as mentioned, based on the BL refactor.

Only patch 1/4 could be considered for net, but still included because
somewhat related to the others and to keep my life easy.

Paolo Abeni (4):
  mptcp: avoid unneeded subflow-level drops.
  mptcp: fix receive space time initialization.
  mptcp: better mptcp-level rtt estimator
  mptcp: add receive queue awareness in tcp_rcv_space_adjust()

 net/mptcp/options.c  |  31 ++++++++
 net/mptcp/protocol.c | 177 ++++++++++++++++++++++++++-----------------
 net/mptcp/protocol.h |  15 +++-
 net/mptcp/subflow.c  |   2 -
 4 files changed, 150 insertions(+), 75 deletions(-)

-- 
2.51.0
Re: [PATCH mptcp-next 0/4] mptcp: autotune related improvement
Posted by Matthieu Baerts 3 weeks, 5 days ago
Hi Paolo,

On 31/10/2025 18:29, Paolo Abeni wrote:
> This series collects a few follow-up for the backlog refactor, with some
> of them posing as fixes just to confuse the enemy (or feel the season
> mood)

:)
> Targeting net-next as the issues addressed are very old, the change
> is quite invasive and, as mentioned, based on the BL refactor.
> 
> Only patch 1/4 could be considered for net, but still included because
> somewhat related to the others and to keep my life easy.

It makes sense!

Thank you for the fixes and improvements!

Note: this is not a review. Just to let you know I manually applied this
series on top of the "mptcp: introduce backlog processing" series to
avoid conflicts. I guess that was the intension. If you want this to be
automated to get results quicker, you can add a line like this one in
the cover-letter:

Based-on: <cover.1761576117.git.pabeni@redhat.com>

While at it, I also rebased the above series on top of the export
branch, and I had a small conflict with Eric's latest series: "tcp: fix
receive autotune again". That's because I removed an extra line in the
v3 that got applied.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-next 0/4] mptcp: autotune related improvement
Posted by MPTCP CI 3 weeks, 5 days ago
Hi Paolo,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Unstable: 1 failed test(s): selftest_mptcp_connect_sendfile - Critical: 1 Call Trace(s) - Critical: Global Timeout ❌
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Critical: 1 Call Trace(s) - Critical: Global Timeout ❌
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/18994741164

Initiator: Matthieu Baerts (NGI0)
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/7e6786f6a20f
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1018332


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)