From: Geliang Tang <tanggeliang@kylinos.cn>

v3:
 - close(pipefds[1]) in main() instead of process_one_client().
 - close(pipefds[0]) on the server side too.
 - patch 2 and patch 3 for -next

v2:
 - patch 2: we should address this resource leak by adding the missing
   close() calls on the server side, rather than by removing the correct
   existing ones on the client side.
 - patch 3: fix more error messages as Matt suggested.
 - Link: https://patchwork.kernel.org/project/mptcp/cover/cover.1756872050.git.geliang@kernel.org/

This patch series addresses several resource management issues in the MPTCP
sockopt selftests.

Geliang Tang (3):
  selftests: mptcp: sockopt: fix error messages
  selftests: mptcp: close server file descriptors
  selftests: mptcp: close server IPC descriptors

 tools/testing/selftests/net/mptcp/mptcp_inq.c |  9 +++++--
 .../selftests/net/mptcp/mptcp_sockopt.c       | 25 +++++++++++++------
 2 files changed, 24 insertions(+), 10 deletions(-)

-- 
2.48.1

Hi Geliang,

On 12/09/2025 05:40, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v3:
>  - close(pipefds[1]) in main() instead of process_one_client().
>  - close(pipefds[0]) on the server side too.
>  - patch 2 and patch 3 for -next

Thank you for the v3, it looks good to me:

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

On 12/09/2025 09:57, Matthieu Baerts wrote:
> Hi Geliang,
> 
> On 12/09/2025 05:40, Geliang Tang wrote:
>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>
>> v3:
>>  - close(pipefds[1]) in main() instead of process_one_client().
>>  - close(pipefds[0]) on the server side too.
>>  - patch 2 and patch 3 for -next
> 
> Thank you for the v3, it looks good to me:

Now in our tree:

New patches for t/upstream-net and t/upstream:
- 7c7fe7c32111: selftests: mptcp: sockopt: fix error messages
- Results: 334d39b0b584..b48b45f8e99e (export-net)
- Results: 46669ecf1c8e..ed231f9fe47a (export)

New patches for t/upstream:
- eb209d77293c: selftests: mptcp: close server file descriptors
- e08574afdef6: selftests: mptcp: close server IPC descriptors
- Results: ed231f9fe47a..9436c7dff71b (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/7394e96db0aa6f0beb5d75295cff4a17a710539d/checks
- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/fa24bbd5e317dc576d9918261ba2bd27235e3077/checks


Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Unstable: 1 failed test(s): packetdrill_mp_capable 🔴
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/17664113196

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/b2ddd676d6f6
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1001578


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)