[PATCH mptcp-net v2 0/3] misc fixes for sockopt selftests

Geliang Tang posted 3 patches 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1756872050.git.geliang@kernel.org
There is a newer version of this series
tools/testing/selftests/net/mptcp/mptcp_inq.c  |  2 ++
.../selftests/net/mptcp/mptcp_sockopt.c        | 18 ++++++++++++------
2 files changed, 14 insertions(+), 6 deletions(-)
[PATCH mptcp-net v2 0/3] misc fixes for sockopt selftests
Posted by Geliang Tang 2 weeks ago
v2:
 - patch 2: we should address this resource leak by adding the missing
   close() calls on the server side, rather than by removing the correct
   existing ones on the client side.
 - patch 3: fix more error messages as Matt suggested.

This patch series addresses several resource management issues in the MPTCP
sockopt selftests.

Geliang Tang (3):
  selftests: mptcp: close server file descriptor
  selftests: mptcp: close IPC descriptor on server side
  selftests: mptcp: sockopt: fix error messages

 tools/testing/selftests/net/mptcp/mptcp_inq.c  |  2 ++
 .../selftests/net/mptcp/mptcp_sockopt.c        | 18 ++++++++++++------
 2 files changed, 14 insertions(+), 6 deletions(-)

-- 
2.48.1
Re: [PATCH mptcp-net v2 0/3] misc fixes for sockopt selftests
Posted by MPTCP CI 2 weeks ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Unstable: 1 failed test(s): packetdrill_dss 🔴
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/17423040759

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/c5af9373827e
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=998230


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)