[PATCH mptcp-next v3 00/14] selftests: consolidate TCP_INQ testing into sockopt

Geliang Tang posted 14 patches 3 weeks, 1 day ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1756200029.git.tanggeliang@kylinos.cn
There is a newer version of this series
tools/testing/selftests/net/mptcp/.gitignore  |   1 -
tools/testing/selftests/net/mptcp/Makefile    |   2 +-
tools/testing/selftests/net/mptcp/mptcp_inq.c | 608 ------------------
.../selftests/net/mptcp/mptcp_sockopt.c       | 346 ++++++++--
.../selftests/net/mptcp/mptcp_sockopt.sh      |   8 +-
5 files changed, 296 insertions(+), 669 deletions(-)
delete mode 100644 tools/testing/selftests/net/mptcp/mptcp_inq.c
[PATCH mptcp-next v3 00/14] selftests: consolidate TCP_INQ testing into sockopt
Posted by Geliang Tang 3 weeks, 1 day ago
From: Geliang Tang <tanggeliang@kylinos.cn>

v3:
 - No longer using process_one_client_inq() and connect_one_server_inq()
   for switching; instead, the inq-related code has been merged into
   process_one_client() and connect_one_server().

v2:
 - patch 4, a new patch, add do_setsockopt_inq helper.
 - cleanups.
 - https://patchwork.kernel.org/project/mptcp/cover/cover.1754664106.git.tanggeliang@kylinos.cn/

v1:
 - https://patchwork.kernel.org/project/mptcp/cover/cover.1754620968.git.tanggeliang@kylinos.cn/

This series consolidates the TCP_INQ test functionality from mptcp_inq
into mptcp_sockopt, simplifying the test suite while maintaining full
test coverage.

Geliang Tang (14):
  selftests: mptcp: sockopt: replace /dev/urandom with getrandom
  selftests: mptcp: sockopt: add protocol arguments
  selftests: mptcp: sockopt: add inq argument
  selftests: mptcp: sockopt: set TCP_INQ on accepted sockets
  selftests: mptcp: sockopt: use unix socket instead of pipe
  selftests: mptcp: sockopt: read eof at the end of process_one_client
  selftests: mptcp: sockopt: use recvmsg instead of read
  selftests: mptcp: sockopt: read one byte first
  selftests: mptcp: sockopt: add large data transfer tests
  selftests: mptcp: sockopt: add wait_for_ack
  selftests: mptcp: sockopt: set FIONREAD ioctl
  selftests: mptcp: sockopt: add check_tcp_inq helper
  selftests: mptcp: sockopt: replace mptcp_inq with sockopt
  selftests: mptcp: sockopt: remove obsolete mptcp_inq

 tools/testing/selftests/net/mptcp/.gitignore  |   1 -
 tools/testing/selftests/net/mptcp/Makefile    |   2 +-
 tools/testing/selftests/net/mptcp/mptcp_inq.c | 608 ------------------
 .../selftests/net/mptcp/mptcp_sockopt.c       | 346 ++++++++--
 .../selftests/net/mptcp/mptcp_sockopt.sh      |   8 +-
 5 files changed, 296 insertions(+), 669 deletions(-)
 delete mode 100644 tools/testing/selftests/net/mptcp/mptcp_inq.c

-- 
2.48.1
Re: [PATCH mptcp-next v3 00/14] selftests: consolidate TCP_INQ testing into sockopt
Posted by MPTCP CI 3 weeks, 1 day ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Unstable: 1 failed test(s): selftest_mptcp_connect 🔴
- KVM Validation: debug: Unstable: 1 failed test(s): selftest_mptcp_connect 🔴
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/17234297108

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/2b989c1de52d
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=995595


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)