[PATCH mptcp-next 0/6] refactor MPTCP socket option handling

Geliang Tang posted 6 patches 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1754986557.git.tanggeliang@kylinos.cn
net/mptcp/sockopt.c | 215 +++++++++++++++++++++++++++++---------------
1 file changed, 145 insertions(+), 70 deletions(-)
[PATCH mptcp-next 0/6] refactor MPTCP socket option handling
Posted by Geliang Tang 1 month ago
From: Geliang Tang <tanggeliang@kylinos.cn>

This series restructures MPTCP socket option implementation to improve
maintainability and consistency. We introduce dedicated helper functions
for different option levels (SOL_SOCKET, SOL_IP, SOL_IPV6, SOL_TCP) and
propagation scopes (first subflow vs. all subflows), addressing current
code fragmentation.

Geliang Tang (6):
  mptcp: add helper for setsockopt on first subflow only
  mptcp: handle SOL_SOCKET options on first subflow only
  mptcp: refactor IP socket option handling for first subflow
  mptcp: extract IPv6 socket option handling for first subflow
  mptcp: handle SOL_TCP options on all subflows
  mptcp: handle IP socket options on all subflows

 net/mptcp/sockopt.c | 215 +++++++++++++++++++++++++++++---------------
 1 file changed, 145 insertions(+), 70 deletions(-)

-- 
2.48.1
Re: [PATCH mptcp-next 0/6] refactor MPTCP socket option handling
Posted by MPTCP CI 1 month ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Unstable: 1 failed test(s): selftest_mptcp_connect 🔴
- KVM Validation: debug: Unstable: 1 failed test(s): packetdrill_mp_join 🔴
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/16903519178

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/54fd10adb571
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=990414


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)