From: Geliang Tang <tanggeliang@kylinos.cn>

v5:
 - new selftests for MD5.

Depends on: selftests: consolidate TCP_INQ testing into sockopt, v2
Based-on: <cover.1754664106.git.tanggeliang@kylinos.cn>

v4:
 - drop CONFIG_TCP_MD5SIG check.
 - drop sk_state check.
 - use WARN_ON_ONCE for __mptcp_try_fallback().

v3:
 - limit the use of these options for listened and closed state.
 - check the return value of __mptcp_try_fallback().

v2:
 - trigger fallback to TCP.
 - check CONFIG_TCP_MD5SIG.
 - update MD5 comment.
 - drop selftests, packetdrill tests will be added later.

This series introduces support for TCP_MD5SIG socket options in MPTCP along
with code improvements:

Patch 1: Refactors TCP_MAXSEG getsockopt handling to improve code
consistency
Patch 2: Adds setsockopt support for TCP_MD5SIG/TCP_MD5SIG_EXT (first
subflow only)

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/575

Geliang Tang (8):
  mptcp: handle TCP_MAXSEG getsockopt in common case
  mptcp: setsockopt support for TCP_MD5SIG
  selftests: mptcp: sockopt: set REUSEADDR opt helper
  selftests: mptcp: sockopt: add md5 argument
  selftests: mptcp: sockopt: implement TCP_MD5SIG support
  selftests: mptcp: sockopt: extend MD5 support for TCP_MD5SIG_EXT
  selftests: mptcp: sockopt: handle MD5 in connection processing
  selftests: mptcp: sockopt: add TCP_MD5SIG test cases

 net/mptcp/sockopt.c                           | 18 ++--
 net/mptcp/subflow.c                           |  3 +
 tools/testing/selftests/net/mptcp/config      |  3 +
 .../selftests/net/mptcp/mptcp_sockopt.c       | 87 +++++++++++++++++--
 .../selftests/net/mptcp/mptcp_sockopt.sh      | 49 +++++++++++
 5 files changed, 147 insertions(+), 13 deletions(-)

-- 
2.48.1

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Unstable: 1 failed test(s): packetdrill_sockopts 🔴
- KVM Validation: debug: Unstable: 1 failed test(s): packetdrill_sockopts 🔴
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/16863216520

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/5e17ac2b0930
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=989716


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)