From: Geliang Tang <tanggeliang@kylinos.cn>

This series introduces support for TCP_MD5SIG socket options in MPTCP along
with code improvements and test cases:

Patch 1: Refactors TCP_MAXSEG getsockopt handling to improve code
consistency
Patch 2: Adds setsockopt support for TCP_MD5SIG/TCP_MD5SIG_EXT (first
subflow only)
Patch 3: Implements selftests for the new MD5SIG functionality

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/575

Geliang Tang (3):
  mptcp: Handle TCP_MAXSEG getsockopt in common case
  mptcp: setsockopt support for TCP_MD5SIG
  selftests: mptcp: add TCP_MD5SIG tests in sockopt

 net/mptcp/sockopt.c                           | 10 +--
 tools/testing/selftests/net/mptcp/config      |  1 +
 .../selftests/net/mptcp/mptcp_sockopt.c       | 67 +++++++++++++++++++
 3 files changed, 74 insertions(+), 4 deletions(-)

-- 
2.48.1

Hi Geliang,

On 30/07/2025 09:22, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> This series introduces support for TCP_MD5SIG socket options in MPTCP along
> with code improvements and test cases:
> 
> Patch 1: Refactors TCP_MAXSEG getsockopt handling to improve code
> consistency
> Patch 2: Adds setsockopt support for TCP_MD5SIG/TCP_MD5SIG_EXT (first
> subflow only)
> Patch 3: Implements selftests for the new MD5SIG functionality

Thank you for looking at that!

I have some comments, please see the individual patches.

> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/575

Can you copy/move this tag to patch 2/3 please?

(Also, I think patch 2 might be seen as a fix, similar to what has been
done with TCP_KEEP*, etc.)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Unstable: 2 failed test(s): packetdrill_sockopts selftest_mptcp_connect 🔴
- KVM Validation: debug: Unstable: 2 failed test(s): packetdrill_sockopts selftest_mptcp_connect 🔴
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/16616393711

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/5bf25749282c
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=986936


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)