From: Geliang Tang <tanggeliang@kylinos.cn>

This series optimizes MPTCP's ADD_ADDR retransmission timeout:

1. Renames sysctl to add_addr_timeout_max for clearer semantics
2. Makes timeout adaptive to subflow RTT
3. Updates selftests for the rename

The adaptive timeout improves subflow establishment responsiveness
while maintaining reliability through the max timeout cap. The rename
provides better configuration clarity.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/576

Geliang Tang (3):
  mptcp: rename add_addr_timeout to add_addr_timeout_max
  mptcp: make ADD_ADDR timeout adaptive to subflow RTT
  selftests: mptcp: update for add_addr_timeout_max rename

 Documentation/networking/mptcp-sysctl.rst     |  6 ++---
 net/mptcp/ctrl.c                              | 12 ++++-----
 net/mptcp/pm.c                                | 27 ++++++++++++++++---
 net/mptcp/protocol.h                          |  2 +-
 .../testing/selftests/net/mptcp/mptcp_join.sh |  8 +++---
 5 files changed, 38 insertions(+), 17 deletions(-)

-- 
2.48.1

Hi Geliang,

On 29/07/2025 10:22, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> This series optimizes MPTCP's ADD_ADDR retransmission timeout:
> 
> 1. Renames sysctl to add_addr_timeout_max for clearer semantics
> 2. Makes timeout adaptive to subflow RTT
> 3. Updates selftests for the rename
> 
> The adaptive timeout improves subflow establishment responsiveness
> while maintaining reliability through the max timeout cap. The rename
> provides better configuration clarity.

Thank you for working on that. I have some comments, please see the
individual patches.

> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/576

Better to (also) put that in the last patch closing the ticket, so
GitHub can automatically close it when this patch will be applied.

> Geliang Tang (3):
>   mptcp: rename add_addr_timeout to add_addr_timeout_max
>   mptcp: make ADD_ADDR timeout adaptive to subflow RTT
>   selftests: mptcp: update for add_addr_timeout_max rename
> 
>  Documentation/networking/mptcp-sysctl.rst     |  6 ++---
>  net/mptcp/ctrl.c                              | 12 ++++-----
>  net/mptcp/pm.c                                | 27 ++++++++++++++++---
>  net/mptcp/protocol.h                          |  2 +-
>  .../testing/selftests/net/mptcp/mptcp_join.sh |  8 +++---
>  5 files changed, 38 insertions(+), 17 deletions(-)
> 

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Unstable: 2 failed test(s): packetdrill_add_addr selftest_mptcp_connect 🔴
- KVM Validation: debug: Unstable: 3 failed test(s): packetdrill_add_addr packetdrill_sockopts selftest_mptcp_connect_checksum 🔴
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/16591166379

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/4e382e2fda74
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=986638


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)