[PATCH mptcp-next v4 0/2] Squash to "implement mptcp read_sock" v8

Geliang Tang posted 2 patches 2 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1752197546.git.tanggeliang@kylinos.cn
include/net/tcp.h    | 23 ++++++++++++++
net/ipv4/tcp.c       | 73 +++++++-----------------------------------
net/mptcp/protocol.c | 75 +++++++++++++++-----------------------------
3 files changed, 59 insertions(+), 112 deletions(-)
[PATCH mptcp-next v4 0/2] Squash to "implement mptcp read_sock" v8
Posted by Geliang Tang 2 months, 1 week ago
From: Geliang Tang <tanggeliang@kylinos.cn>

v4:
 - No need to handle "SOCK_DONE" in MPTCP, drop "SOCK_DONE" checks in
   mptcp_recvmsg and mptcp_splice_read.

v3:
 - rename mptcp_recv_should_stop to tcp_recv_should_stop and use it for
   TCP too.

v2:
 - use mptcp_recv_should_stop instead of
                if (sk->sk_err ||
                    sk->sk_state == TCP_CLOSE ||
                    (sk->sk_shutdown & RCV_SHUTDOWN) ||
                    !timeo ||
                    signal_pending(current))
  in mptcp_recvmsg.

 - use mptcp_recv_should_stop instead of
                if (sk->sk_err || sk->sk_state == TCP_CLOSE ||
                    (sk->sk_shutdown & RCV_SHUTDOWN) ||
                    signal_pending(current))
   in mptcp_splice_read.

v1:
 Drop "shutdown" parameter of mptcp_recv_should_stop.

Based-on: <cover.1752045499.git.tanggeliang@kylinos.cn>

Geliang Tang (2):
  Squash to "mptcp: add recv_should_stop helper"
  Squash to "mptcp: implement .splice_read"

 include/net/tcp.h    | 23 ++++++++++++++
 net/ipv4/tcp.c       | 73 +++++++-----------------------------------
 net/mptcp/protocol.c | 75 +++++++++++++++-----------------------------
 3 files changed, 59 insertions(+), 112 deletions(-)

-- 
2.48.1
Re: [PATCH mptcp-next v4 0/2] Squash to "implement mptcp read_sock" v8
Posted by MPTCP CI 2 months, 1 week ago
Hi Geliang,

Thank you for your modifications, that's great!

But sadly, our CI spotted some issues with it when trying to build it.

You can find more details there:

  https://github.com/multipath-tcp/mptcp_net-next/actions/runs/16214201126

Status: failure
Initiator: Matthieu Baerts (NGI0)
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/377a22ce925b
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=981305

Feel free to reply to this email if you cannot access logs, if you need
some support to fix the error, if this doesn't seem to be caused by your
modifications or if the error is a false positive one.

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Re: [PATCH mptcp-next v4 0/2] Squash to "implement mptcp read_sock" v8
Posted by MPTCP CI 2 months, 1 week ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/16214201123

Initiator: Matthieu Baerts (NGI0)
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/377a22ce925b
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=981305


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)