[v2] Add TCP_MAXSEG socket option support

[PATCH mptcp-next v2 0/3] Add TCP_MAXSEG socket option support

Geliang Tang posted 3 patches 7 months, 3 weeks ago

Diff against v1 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1745401025.git.tanggeliang@kylinos.cn

There is a newer version of this series

include/linux/tcp.h                           |  1 +
net/ipv4/tcp.c                                | 24 ++++++++++++-------
net/mptcp/protocol.h                          |  1 +
net/mptcp/sockopt.c                           | 24 +++++++++++++++++++
.../selftests/net/mptcp/mptcp_sockopt.c       | 22 +++++++++++++++++
5 files changed, 63 insertions(+), 9 deletions(-)

Expand all Fold all

[PATCH mptcp-next v2 0/3] Add TCP_MAXSEG socket option support

Posted by Geliang Tang 7 months, 3 weeks ago

From: Geliang Tang <tanggeliang@kylinos.cn>

v2:
 - add a new helper tcp_sock_set_maxseg.
 - add maxseg member of struct mptcp_sock.
 - add mptcp_setsockopt_all_subflows helper.
 - invoke mptcp_setsockopt_all_subflows under the msk socket lock.
 - drop mptcp_getsockopt_sol_tcp_maxseg, use mptcp_put_int_option
   instead.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/515

Geliang Tang (3):
  tcp: add tcp_sock_set_maxseg
  mptcp: add TCP_MAXSEG sockopt support
  selftests: mptcp: sockopt: add TCP_MAXSEG sockopt tests

 include/linux/tcp.h                           |  1 +
 net/ipv4/tcp.c                                | 24 ++++++++++++-------
 net/mptcp/protocol.h                          |  1 +
 net/mptcp/sockopt.c                           | 24 +++++++++++++++++++
 .../selftests/net/mptcp/mptcp_sockopt.c       | 22 +++++++++++++++++
 5 files changed, 63 insertions(+), 9 deletions(-)

-- 
2.43.0

Re: [PATCH mptcp-next v2 0/3] Add TCP_MAXSEG socket option support

Posted by Matthieu Baerts 7 months, 2 weeks ago

Hi Geliang,

On 23/04/2025 11:40, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v2:
>  - add a new helper tcp_sock_set_maxseg.
>  - add maxseg member of struct mptcp_sock.
>  - add mptcp_setsockopt_all_subflows helper.
>  - invoke mptcp_setsockopt_all_subflows under the msk socket lock.
>  - drop mptcp_getsockopt_sol_tcp_maxseg, use mptcp_put_int_option
>    instead.

Thank you for the update.

> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/515
> 
> Geliang Tang (3):
>   tcp: add tcp_sock_set_maxseg
>   mptcp: add TCP_MAXSEG sockopt support
>   selftests: mptcp: sockopt: add TCP_MAXSEG sockopt tests

The two first patches look almost OK to me, please see the individual
comments. I think we can drop the 3rd one.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.