From: Geliang Tang <tanggeliang@kylinos.cn>

v3:
 - update userspace selftests.

v2:
 - squash patch 1 into patch 2 as Mat suggested.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/403

Geliang Tang (3):
  mptcp: pm: userspace: drop delete_local_addr helper
  selftests: mptcp: join: update userspace dump_addr outputs
  selftests: mptcp: userspace: send RM_ADDR between server and client

 net/mptcp/pm_userspace.c                      | 37 +++----------------
 .../testing/selftests/net/mptcp/mptcp_join.sh |  6 +--
 .../selftests/net/mptcp/userspace_pm.sh       | 12 ++++++
 3 files changed, 20 insertions(+), 35 deletions(-)

-- 
2.43.0

On Wed, 16 Apr 2025, Geliang Tang wrote:

> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> v3:
> - update userspace selftests.
>
> v2:
> - squash patch 1 into patch 2 as Mat suggested.
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/403
>
> Geliang Tang (3):
>  mptcp: pm: userspace: drop delete_local_addr helper
>  selftests: mptcp: join: update userspace dump_addr outputs
>  selftests: mptcp: userspace: send RM_ADDR between server and client
>
> net/mptcp/pm_userspace.c                      | 37 +++----------------
> .../testing/selftests/net/mptcp/mptcp_join.sh |  6 +--
> .../selftests/net/mptcp/userspace_pm.sh       | 12 ++++++
> 3 files changed, 20 insertions(+), 35 deletions(-)
>

The series LGTM, but I would like to do some more testing with mptcpd 
(outside the unit tests) to double-check behavior before upstreaming to 
net-next or -net. I won't be able to get to that before the middle of next 
week, though. Matthieu and I can talk about it on Wednesday.

Reviewed-by: Mat Martineau <martineau@kernel.org>

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Unstable: 1 failed test(s): packetdrill_mp_capable 🔴
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/14487269508

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/56310471b2fd
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=953862


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)