[v1] BCC: python: support fmod_ret

[PATCH 0/2] BCC: python: support fmod_ret

Posted by Gang Yan 8 months, 2 weeks ago

Support fmod_ret, and add a useful tool for mptcp, also
the interface can be verified with this function.

Gang Yan (2):
  BCC: Python: Support 'fmod_ret' method for eBPF
  BCC: python: add a useful tool for mptcp

 src/python/bcc/__init__.py | 43 ++++++++++++++++++++
 tools/mptcpboost.py        | 82 ++++++++++++++++++++++++++++++++++++++
 tools/mptcpboost.txt       | 22 ++++++++++
 3 files changed, 147 insertions(+)
 create mode 100644 tools/mptcpboost.py
 create mode 100644 tools/mptcpboost.txt

-- 
2.25.1

Re: [PATCH 0/2] BCC: python: support fmod_ret

Posted by Matthieu Baerts 8 months, 1 week ago

Hi Gang,

On 07/04/2025 04:37, Gang Yan wrote:
> Support fmod_ret, and add a useful tool for mptcp, also
> the interface can be verified with this function.
> 
> Gang Yan (2):
>   BCC: Python: Support 'fmod_ret' method for eBPF
>   BCC: python: add a useful tool for mptcp

Thank you for looking at this!

Personally, I don't know how BCC is working internally, but the
modifications seem to make sense.

I have a few comments, but apart from that, feel free to create the PR
on BCC repo.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Re: [PATCH 0/2] BCC: python: support fmod_ret

Posted by Gang Yan 8 months, 1 week ago

On Mon, Apr 07, 2025 at 11:07:04AM +0200, Matthieu Baerts wrote:
Hi Matt,
> Hi Gang,
> 
> On 07/04/2025 04:37, Gang Yan wrote:
> > Support fmod_ret, and add a useful tool for mptcp, also
> > the interface can be verified with this function.
> > 
> > Gang Yan (2):
> >   BCC: Python: Support 'fmod_ret' method for eBPF
> >   BCC: python: add a useful tool for mptcp
> 
> Thank you for looking at this!
> 
> Personally, I don't know how BCC is working internally, but the
> modifications seem to make sense.
> 
> I have a few comments, but apart from that, feel free to create the PR
> on BCC repo.
>

Thanks for the comments!

Can I add your <Reviewd-by> in this PR?

> Cheers,
> Matt
> -- 
> Sponsored by the NGI0 Core fund.
> 
>

Re: [PATCH 0/2] BCC: python: support fmod_ret

Posted by Matthieu Baerts 8 months, 1 week ago

Hi Gang,

On 08/04/2025 04:02, Gang Yan wrote:
> On Mon, Apr 07, 2025 at 11:07:04AM +0200, Matthieu Baerts wrote:
> Hi Matt,
>> Hi Gang,
>>
>> On 07/04/2025 04:37, Gang Yan wrote:
>>> Support fmod_ret, and add a useful tool for mptcp, also
>>> the interface can be verified with this function.
>>>
>>> Gang Yan (2):
>>>   BCC: Python: Support 'fmod_ret' method for eBPF
>>>   BCC: python: add a useful tool for mptcp
>>
>> Thank you for looking at this!
>>
>> Personally, I don't know how BCC is working internally, but the
>> modifications seem to make sense.
>>
>> I have a few comments, but apart from that, feel free to create the PR
>> on BCC repo.
>>
> 
> Thanks for the comments!
> 
> Can I add your <Reviewd-by> in this PR?

I don't think they use these tags in BCC. (If any, it should be more
Acked-by). Maybe better to add something like that in the Pull Request
message:

  @matttbe from the MPTCP kernel team had a look at the new tool.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.