[PATCH mptcp-next v2 11/11] mptcp: drop subflow contexts in mptcp_sched_data

Geliang Tang posted 11 patches 1 month ago
There is a newer version of this series
[PATCH mptcp-next v2 11/11] mptcp: drop subflow contexts in mptcp_sched_data
Posted by Geliang Tang 1 month ago
From: Geliang Tang <tanggeliang@kylinos.cn>

The mptcp_subflow_sched bpf_iter is added now, it's better to use the
helper bpf_for_each(mptcp_subflow_sched) to traverse all subflows on the
conn_list of an MPTCP socket and then call kfunc to modify the fields of
each subflow in the WIP MPTCP BPF packet scheduler examples, instead of
converting them to a fixed array. With this helper, we can get rid of
this subflow array "contexts" and the size of it "subflows" in struct
mptcp_sched_data.

Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
 include/net/mptcp.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/net/mptcp.h b/include/net/mptcp.h
index bd3d1b3654dd..0083af204000 100644
--- a/include/net/mptcp.h
+++ b/include/net/mptcp.h
@@ -100,11 +100,7 @@ struct mptcp_out_options {
 #define MPTCP_SCHED_MAX		128
 #define MPTCP_SCHED_BUF_MAX	(MPTCP_SCHED_NAME_MAX * MPTCP_SCHED_MAX)
 
-#define MPTCP_SUBFLOWS_MAX	8
-
 struct mptcp_sched_data {
-	u8	subflows;
-	struct mptcp_subflow_context *contexts[MPTCP_SUBFLOWS_MAX];
 	struct task_struct *bpf_iter_task;
 };
 
-- 
2.43.0