a couple of incremental improvements on top of the pending rx path
refactor: patch 1 dismiss __mptcp_rmem(), patch 2 optimize a bit 
__mptcp_move_skbs()

Based-on: <cover.1733486870.git.pabeni@redhat.com>

Paolo Abeni (2):
  mptcp: dismiss __mptcp_rmem()
  mptcp: micro-optimize __mptcp_move_skb()

 net/mptcp/protocol.c | 113 +++++++++++++++++++------------------------
 net/mptcp/protocol.h |  13 ++---
 2 files changed, 55 insertions(+), 71 deletions(-)

-- 
2.45.2

Hi Paolo, Mat,

On 12/12/2024 17:58, Paolo Abeni wrote:
> a couple of incremental improvements on top of the pending rx path
> refactor: patch 1 dismiss __mptcp_rmem(), patch 2 optimize a bit 
> __mptcp_move_skbs()

Thank you for the patches and the reviews!

Now in our tree (with a small modification of mptcp_next_subflow() as
suggested by CheckPatch [1])

[1] https://github.com/multipath-tcp/mptcp_net-next/actions/runs/12301307406

New patches for t/upstream:
- 94c0aa6980ba: mptcp: dismiss __mptcp_rmem()
- 515e071ef7f6: mptcp: micro-optimize __mptcp_move_skb()
- Results: 9213903d77ba..51bd6a121e25 (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/fd12ae115620bb5aed8fa1c1182edb9ab226494a/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

On Thu, 12 Dec 2024, Paolo Abeni wrote:

> a couple of incremental improvements on top of the pending rx path
> refactor: patch 1 dismiss __mptcp_rmem(), patch 2 optimize a bit
> __mptcp_move_skbs()
>

Both LGTM, thanks Paolo.

Reviewed-by: Mat Martineau <martineau@kernel.org>

> Based-on: <cover.1733486870.git.pabeni@redhat.com>
>
> Paolo Abeni (2):
>  mptcp: dismiss __mptcp_rmem()
>  mptcp: micro-optimize __mptcp_move_skb()
>
> net/mptcp/protocol.c | 113 +++++++++++++++++++------------------------
> net/mptcp/protocol.h |  13 ++---
> 2 files changed, 55 insertions(+), 71 deletions(-)
>
> -- 
> 2.45.2
>
>
>

Hi Paolo,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/12301307404

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/63734435a74d
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=917303


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)