From: Geliang Tang <tanggeliang@kylinos.cn>

v4:
 - Use netns_new/netns_free instead of create_netns/cleanup_netns as
Martin suggested.

The commit 1e115a58be0ff ("selftests/bpf: netns_new() and netns_free()
helpers.") now in bpf-next makes v2 of this set useless. v3 only uses
these new helpers in mptcp selftests and drops other patches.

v3:
https://patchwork.kernel.org/project/mptcp/cover/cover.1728530836.git.tanggeliang@kylinos.cn/

v2:
https://patchwork.kernel.org/project/mptcp/cover/cover.1715821541.git.tanggeliang@kylinos.cn/

Geliang Tang (4):
  selftests/bpf: Drop netns helpers in mptcp
  Squash to "selftests/bpf: Add mptcp_subflow bpf_iter subtest"
  Squash to "selftests/bpf: Add bpf scheduler test"
  Squash to "selftests/bpf: Add bpf_first scheduler & test"

 .../testing/selftests/bpf/prog_tests/mptcp.c  | 78 +++++++------------
 1 file changed, 30 insertions(+), 48 deletions(-)

-- 
2.45.2

Hi Geliang,

On 30/10/2024 05:03, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v4:
>  - Use netns_new/netns_free instead of create_netns/cleanup_netns as
> Martin suggested.
> 
> The commit 1e115a58be0ff ("selftests/bpf: netns_new() and netns_free()
> helpers.") now in bpf-next makes v2 of this set useless. v3 only uses
> these new helpers in mptcp selftests and drops other patches.

Thank you for the modifications! The new version looks good to me:

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

If that's OK, I will wait for a review from the BPF maintainers before
applying these patches in our repo, not to do too many manipulations
just in case an (unexpected) new version is required.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Matt,

On Wed, 2024-10-30 at 18:34 +0100, Matthieu Baerts wrote:
> Hi Geliang,
> 
> On 30/10/2024 05:03, Geliang Tang wrote:
> > From: Geliang Tang <tanggeliang@kylinos.cn>
> > 
> > v4:
> >  - Use netns_new/netns_free instead of create_netns/cleanup_netns
> > as
> > Martin suggested.
> > 
> > The commit 1e115a58be0ff ("selftests/bpf: netns_new() and
> > netns_free()
> > helpers.") now in bpf-next makes v2 of this set useless. v3 only
> > uses
> > these new helpers in mptcp selftests and drops other patches.
> 
> Thank you for the modifications! The new version looks good to me:
> 
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> If that's OK, I will wait for a review from the BPF maintainers
> before
> applying these patches in our repo, not to do too many manipulations
> just in case an (unexpected) new version is required.

Patch 1 has been merged into bpf-next/net by Martin today. Please apply
this set in our repo too. After this, the "add mptcp_subflow bpf_iter"
series in our repo is ready to be sent to upstream.

Thanks,
-Geliang

> 
> Cheers,
> Matt

Hi Geliang,

On 06/11/2024 04:52, Geliang Tang wrote:
> Hi Matt,
> 
> On Wed, 2024-10-30 at 18:34 +0100, Matthieu Baerts wrote:
>> Hi Geliang,
>>
>> On 30/10/2024 05:03, Geliang Tang wrote:
>>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>>
>>> v4:
>>>  - Use netns_new/netns_free instead of create_netns/cleanup_netns
>>> as
>>> Martin suggested.
>>>
>>> The commit 1e115a58be0ff ("selftests/bpf: netns_new() and
>>> netns_free()
>>> helpers.") now in bpf-next makes v2 of this set useless. v3 only
>>> uses
>>> these new helpers in mptcp selftests and drops other patches.
>>
>> Thank you for the modifications! The new version looks good to me:
>>
>> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>>
>> If that's OK, I will wait for a review from the BPF maintainers
>> before
>> applying these patches in our repo, not to do too many manipulations
>> just in case an (unexpected) new version is required.
> 
> Patch 1 has been merged into bpf-next/net by Martin today. Please apply
> this set in our repo too. After this, the "add mptcp_subflow bpf_iter"
> series in our repo is ready to be sent to upstream.

Thanks!

New patches for t/upstream:
- c786bfbfa13f: selftests/bpf: Drop netns helpers in mptcp
- Results: b4f136198f02..ac39b3f1d92b (export)

- de2a335efeba: "squashed" patch 2/4 in "selftests/bpf: Add
mptcp_subflow bpf_iter subtest"
- ea4672e6e042: "squashed" (with conflicts) patch 3/4 in "selftests/bpf:
Add bpf scheduler test"
- 8c6acd6502af: "squashed" patch 4/4 in "selftests/bpf: Add bpf_first
scheduler & test"
- Results: ac39b3f1d92b..370ec37a4049 (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/3fd30039804ef2d1b62fd95d7cadd5a61dd7f542/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/11586931001

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/639f675bca10
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=904491


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)