[PATCH mptcp-next v2 0/6] fixes for "new MPTCP subflow subtest v6"

Geliang Tang posted 6 patches 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1726647599.git.tanggeliang@kylinos.cn
There is a newer version of this series
net/mptcp/bpf.c                               |  6 +--
net/mptcp/protocol.h                          |  3 --
.../testing/selftests/bpf/prog_tests/mptcp.c  | 47 ++++++++++++-------
tools/testing/selftests/bpf/progs/mptcp_bpf.h |  4 +-
4 files changed, 34 insertions(+), 26 deletions(-)
[PATCH mptcp-next v2 0/6] fixes for "new MPTCP subflow subtest v6"
Posted by Geliang Tang 3 months ago
From: Geliang Tang <tanggeliang@kylinos.cn>

v2:
 - two more cleanups, 5-6, use __bpf_kfunc_start_defs/__bpf_kfunc_end_defs
 and drop the declarations of __bpf_kfunc.

1-2 address Martin's comments
3-4 cleanups for endpoint_init

Geliang Tang (6):
  Squash to "selftests/bpf: Add getsockopt to inspect mptcp subflow"
  Squash to "selftests/bpf: Add mptcp subflow subtest"
  selftests/bpf: More subflows for endpoint_init
  Squash to "selftests/bpf: Add bpf scheduler test"
  Squash to "mptcp: add sched_data helpers"
  Squash to "bpf: Export more bpf_burst related functions"

 net/mptcp/bpf.c                               |  6 +--
 net/mptcp/protocol.h                          |  3 --
 .../testing/selftests/bpf/prog_tests/mptcp.c  | 47 ++++++++++++-------
 tools/testing/selftests/bpf/progs/mptcp_bpf.h |  4 +-
 4 files changed, 34 insertions(+), 26 deletions(-)

-- 
2.43.0
Re: [PATCH mptcp-next v2 0/6] fixes for "new MPTCP subflow subtest v6"
Posted by Matthieu Baerts 2 months, 4 weeks ago
Hi Geliang,

On 18/09/2024 10:25, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v2:
>  - two more cleanups, 5-6, use __bpf_kfunc_start_defs/__bpf_kfunc_end_defs
>  and drop the declarations of __bpf_kfunc.
> 
> 1-2 address Martin's comments

As mentioned in my previous email, I only applied these two patches:

New patches for t/upstream:
- a3694ad627fb: "squashed" patch 1/6 in "selftests/bpf: Add getsockopt
to inspect mptcp subflow"
- f75b0ee082dd: "squashed" patch 2/6 in "selftests/bpf: Add mptcp
subflow subtest"
- Results: 1ca27609ee8b..988c8bf8afee (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/3236a730ea9b8d63a159d47275f4408432e492fd/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-next v2 0/6] fixes for "new MPTCP subflow subtest v6"
Posted by MPTCP CI 3 months ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/10918596267

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/a928a1640a28
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=891102


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Re: [PATCH mptcp-next v2 0/6] fixes for "new MPTCP subflow subtest v6"
Posted by MPTCP CI 3 months ago
Hi Geliang,

Thank you for your modifications, that's great!

But sadly, our CI spotted some issues with it when trying to build it.

You can find more details there:

  https://github.com/multipath-tcp/mptcp_net-next/actions/runs/10918596257

Status: failure
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/a928a1640a28
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=891102

Feel free to reply to this email if you cannot access logs, if you need
some support to fix the error, if this doesn't seem to be caused by your
modifications or if the error is a false positive one.

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)