From: Geliang Tang <tanggeliang@kylinos.cn>
Drop ss_search() from run_subflow().
Now ss_search() are only used by bpf_sched tests. It will be dropped
in next step.
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
.../testing/selftests/bpf/prog_tests/mptcp.c | 38 +++++--------------
1 file changed, 10 insertions(+), 28 deletions(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c b/tools/testing/selftests/bpf/prog_tests/mptcp.c
index 73adc58cd776..d4c5209fbfaf 100644
--- a/tools/testing/selftests/bpf/prog_tests/mptcp.c
+++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c
@@ -368,22 +368,9 @@ static int endpoint_init(char *flags)
return -1;
}
-static int _ss_search(char *src, char *dst, char *port, char *keyword)
+static void run_subflow(void)
{
- return SYS_NOFAIL("ip netns exec %s ss -enita src %s dst %s %s %d | grep -q '%s'",
- NS_TEST, src, dst, port, PORT_1, keyword);
-}
-
-static int ss_search(char *src, char *keyword)
-{
- return _ss_search(src, ADDR_1, "dport", keyword);
-}
-
-static void run_subflow(char *new)
-{
- int server_fd, client_fd, err;
- char cc[TCP_CA_NAME_MAX];
- socklen_t len;
+ int server_fd, client_fd;
server_fd = start_mptcp_server(AF_INET, ADDR_1, PORT_1, 0);
if (!ASSERT_GE(server_fd, 0, "start_mptcp_server"))
@@ -393,19 +380,8 @@ static void run_subflow(char *new)
if (!ASSERT_GE(client_fd, 0, "connect to fd"))
goto close_server;
- len = sizeof(cc);
- err = getsockopt(server_fd, SOL_TCP, TCP_CONGESTION, cc, &len);
- if (!ASSERT_OK(err, "getsockopt(server_fd, TCP_CONGESTION)"))
- goto close_client;
-
send_byte(client_fd);
- ASSERT_OK(ss_search(ADDR_1, "fwmark:0x1"), "ss_search fwmark:0x1");
- ASSERT_OK(ss_search(ADDR_2, "fwmark:0x2"), "ss_search fwmark:0x2");
- ASSERT_OK(ss_search(ADDR_1, new), "ss_search new cc");
- ASSERT_OK(ss_search(ADDR_2, cc), "ss_search default cc");
-
-close_client:
close(client_fd);
close_server:
close(server_fd);
@@ -441,7 +417,7 @@ static void test_subflow(void)
if (endpoint_init("subflow") < 0)
goto close_netns;
- run_subflow(skel->data->cc);
+ run_subflow();
close_netns:
cleanup_netns(nstoken);
@@ -470,9 +446,15 @@ static struct nstoken *sched_init(char *flags, char *sched)
return NULL;
}
+static int ss_search(char *src, char *dst, char *port, char *keyword)
+{
+ return SYS_NOFAIL("ip netns exec %s ss -enita src %s dst %s %s %d | grep -q '%s'",
+ NS_TEST, src, dst, port, PORT_1, keyword);
+}
+
static int has_bytes_sent(char *dst)
{
- return _ss_search(ADDR_1, dst, "sport", "bytes_sent:");
+ return ss_search(ADDR_1, dst, "sport", "bytes_sent:");
}
static void send_data_and_verify(char *sched, bool addr1, bool addr2)
--
2.43.0