Hi Paolo,
On 05/07/2024 22:33, Paolo Abeni wrote:
> Issues/501 showed that the NL PM currently don't add corectly removal
> and re-add of signal endpoint.
>
> Patches 1 and 2 addresses the issue, patch 3/4 introduce a related
> self-test, and the last patch address a pre-existing buglet in the
> self-test infra.
>
> v1 -> v2:
> - splitted the first 2 patches
> - fixed accounting in mptcp_pm_remove_anno_addr
> - self-tests depends on subflow_rebuild_header
Thank you for the v2, it looks good to me:
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
I will do a follow-up regarding the re-use of the same ID (if needed --
but I guess yes, because we never mark the ID as available again when we
remove a signal endpoint).
For the issue with Packetdrill, reported by the CI, I think it should be
fixed by this PR:
https://github.com/multipath-tcp/packetdrill/pull/151
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.