[PATCH mptcp-net 3/3] selftests: mptcp: fix error path

Paolo Abeni posted 3 patches 3 months, 3 weeks ago
There is a newer version of this series
[PATCH mptcp-net 3/3] selftests: mptcp: fix error path
Posted by Paolo Abeni 3 months, 3 weeks ago
pm_nl_check_endpoint() currently calls an not existing helper
to mark the test as failed. Fix the wrong call.

Fixes: 03668c65d153 ("selftests: mptcp: join: rework detailed report")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index 228fecee61f9..c4593677a567 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -661,7 +661,7 @@ pm_nl_check_endpoint()
 	done
 
 	if [ -z "${id}" ]; then
-		test_fail "bad test - missing endpoint id"
+		fail_test "bad test - missing endpoint id"
 		return
 	fi
 
-- 
2.45.1
Re: [PATCH mptcp-net 3/3] selftests: mptcp: fix error path
Posted by Matthieu Baerts 3 months, 2 weeks ago
On 28/06/2024 17:54, Paolo Abeni wrote:
> pm_nl_check_endpoint() currently calls an not existing helper
> to mark the test as failed. Fix the wrong call.
> 
> Fixes: 03668c65d153 ("selftests: mptcp: join: rework detailed report")

Good catch!

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.