From: Geliang Tang <tanggeliang@kylinos.cn>

v9:
 - validate the return value of snprintf in patch 2 as Mat suggested.
 - patch 2 depends on "selftests/bpf: Add RUN_MPTCP_TEST macro", so this
   series could be merged in this order:
   1 selftests/bpf: Add mptcp subflow example
   2 selftests/bpf: Add RUN_MPTCP_TEST macro
   3 selftests/bpf: Add mptcp subflow subtest
   4 selftests/bpf: Handle SIGINT when creating netns

v8:
 - update the git metadata to add Nicolas as the git "Author" and add a
   "Co-authored-by" tag with my name in patch 1 as Mat suggested in v7.
 - use send_byte in patch 2 instead of send_recv_data, to make this
   series independent of the commit "selftests/bpf: Export send_recv_data
   helper", which is in bpf-next, but not in mptcp_net-next at this moment.

v7:
 - address Mat's comments in v6 (thanks): drop MPTCP_BASE_TEST and rebased.
 - depends on:
 "refactor mptcp bpf tests" v7
 "export send_byte and send_recv_data" v2

v6:
 - Deponds on "[bpf-next] export send_byte and send_recv_data" series.

v5:
 - #1-#7 Address #76: add new macros MPTCP_BASE_TEST and RUN_MPTCP_TEST.
 - #8-#14 add MPTCP_SCHED_TEST macro.

v4:
 - #1-#5 Address #76: add a new macro RUN_MPTCP_TEST.
 - #6-#11 Cleanups: add send_data_and_verify and SCHED_TEST.

v3:
 - deal with EAGAIN.
 - add _ss_search helper.

v2:
 - fix checkpatch warnings.
 - cleanups.

Geliang Tang (3):
  selftests/bpf: Add mptcp subflow subtest
  selftests/bpf: Handle SIGINT when creating netns
  Squash to "selftests/bpf: Add bpf scheduler test"

Nicolas Rybowski (1):
  selftests/bpf: Add mptcp subflow example

 .../testing/selftests/bpf/prog_tests/mptcp.c  | 143 +++++++++++++++---
 .../selftests/bpf/progs/mptcp_subflow.c       |  70 +++++++++
 2 files changed, 195 insertions(+), 18 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/progs/mptcp_subflow.c

-- 
2.40.1

Hi Geliang, Mat,

On 24/04/2024 03:13, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v9:
>  - validate the return value of snprintf in patch 2 as Mat suggested.
>  - patch 2 depends on "selftests/bpf: Add RUN_MPTCP_TEST macro", so this
>    series could be merged in this order:
>    1 selftests/bpf: Add mptcp subflow example
>    2 selftests/bpf: Add RUN_MPTCP_TEST macro
>    3 selftests/bpf: Add mptcp subflow subtest
>    4 selftests/bpf: Handle SIGINT when creating netns

Thank you for the v9, and for the reviews!

New patches for t/upstream:
- fbbcd761fba3: selftests/bpf: Add mptcp subflow example
- Results: a11773e3c938..97e0136c8e33 (export)

New patches for t/upstream:
- 9961ad9244d7: selftests/bpf: Add mptcp subflow subtest
- 2f83b94e9407: selftests/bpf: Handle SIGINT when creating netns
- 84add332488a: conflict in t/selftests-bpf-Add-bpf-scheduler-test
- bdc876b898a8: conflict in t/selftests-bpf-add-bpf_first-scheduler
- Results: 97e0136c8e33..d3dcecbbf741 (export)

- d7b5a88080f9: "squashed" in "selftests/bpf: Add bpf scheduler test"
- 774ca6584944: Squash to "selftests/bpf: Add bpf scheduler test"
  (removed unused variable)
- Results: d3dcecbbf741..4e475b683f9a (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/de55140562593e303216dad6fd1e925cd618164d/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

On Wed, 24 Apr 2024, Geliang Tang wrote:

> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> v9:
> - validate the return value of snprintf in patch 2 as Mat suggested.
> - patch 2 depends on "selftests/bpf: Add RUN_MPTCP_TEST macro", so this
>   series could be merged in this order:
>   1 selftests/bpf: Add mptcp subflow example
>   2 selftests/bpf: Add RUN_MPTCP_TEST macro
>   3 selftests/bpf: Add mptcp subflow subtest
>   4 selftests/bpf: Handle SIGINT when creating netns

Hi Geliang -

v9 looks good to me, thanks!

Reviewed-by: Mat Martineau <martineau@kernel.org>

>
> v8:
> - update the git metadata to add Nicolas as the git "Author" and add a
>   "Co-authored-by" tag with my name in patch 1 as Mat suggested in v7.
> - use send_byte in patch 2 instead of send_recv_data, to make this
>   series independent of the commit "selftests/bpf: Export send_recv_data
>   helper", which is in bpf-next, but not in mptcp_net-next at this moment.
>
> v7:
> - address Mat's comments in v6 (thanks): drop MPTCP_BASE_TEST and rebased.
> - depends on:
> "refactor mptcp bpf tests" v7
> "export send_byte and send_recv_data" v2
>
> v6:
> - Deponds on "[bpf-next] export send_byte and send_recv_data" series.
>
> v5:
> - #1-#7 Address #76: add new macros MPTCP_BASE_TEST and RUN_MPTCP_TEST.
> - #8-#14 add MPTCP_SCHED_TEST macro.
>
> v4:
> - #1-#5 Address #76: add a new macro RUN_MPTCP_TEST.
> - #6-#11 Cleanups: add send_data_and_verify and SCHED_TEST.
>
> v3:
> - deal with EAGAIN.
> - add _ss_search helper.
>
> v2:
> - fix checkpatch warnings.
> - cleanups.
>
> Geliang Tang (3):
>  selftests/bpf: Add mptcp subflow subtest
>  selftests/bpf: Handle SIGINT when creating netns
>  Squash to "selftests/bpf: Add bpf scheduler test"
>
> Nicolas Rybowski (1):
>  selftests/bpf: Add mptcp subflow example
>
> .../testing/selftests/bpf/prog_tests/mptcp.c  | 143 +++++++++++++++---
> .../selftests/bpf/progs/mptcp_subflow.c       |  70 +++++++++
> 2 files changed, 195 insertions(+), 18 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/progs/mptcp_subflow.c
>
> -- 
> 2.40.1
>
>
>

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8809606528

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/23177691596c
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=847234


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)