From: Geliang Tang <tanggeliang@kylinos.cn>
Move time related code from send_data into send_data_and_verify. Then
send_data can be exported into network_helpers.h as a public function,
reused by mptcp.c and bpf_tcp_ca.c.
Drop duplicate '#include <time.h>', it's included in test_progs.h
already.
Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
---
.../testing/selftests/bpf/prog_tests/mptcp.c | 23 +++++++++----------
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c b/tools/testing/selftests/bpf/prog_tests/mptcp.c
index 5080e680fbe0..aa95bb41d5ea 100644
--- a/tools/testing/selftests/bpf/prog_tests/mptcp.c
+++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c
@@ -5,7 +5,6 @@
#include <linux/const.h>
#include <netinet/in.h>
#include <test_progs.h>
-#include <time.h>
#include "cgroup_helpers.h"
#include "network_helpers.h"
#include "mptcp_sock.skel.h"
@@ -380,16 +379,12 @@ static void *server(void *arg)
static void send_data(int lfd, int fd, char *msg)
{
ssize_t nr_recv = 0, bytes = 0;
- struct timespec start, end;
- unsigned int delta_ms;
pthread_t srv_thread;
void *thread_ret;
char batch[1500];
int err;
WRITE_ONCE(stop, 0);
- if (clock_gettime(CLOCK_MONOTONIC, &start) < 0)
- return;
err = pthread_create(&srv_thread, NULL, server, (void *)(long)lfd);
if (CHECK(err != 0, "pthread_create", "err:%d errno:%d\n", err, errno))
@@ -406,16 +401,9 @@ static void send_data(int lfd, int fd, char *msg)
bytes += nr_recv;
}
- if (clock_gettime(CLOCK_MONOTONIC, &end) < 0)
- return;
-
- delta_ms = (end.tv_sec - start.tv_sec) * 1000 + (end.tv_nsec - start.tv_nsec) / 1000000;
-
CHECK(bytes != total_bytes, "recv", "%zd != %u nr_recv:%zd errno:%d\n",
bytes, total_bytes, nr_recv, errno);
- printf("%s: %u ms\n", msg, delta_ms);
-
WRITE_ONCE(stop, 1);
pthread_join(srv_thread, &thread_ret);
@@ -459,7 +447,9 @@ static int has_bytes_sent(char *addr)
static void send_data_and_verify(char *sched, char *addr1, char *addr2)
{
+ struct timespec start, end;
int server_fd, client_fd;
+ unsigned int delta_ms;
server_fd = start_mptcp_server(AF_INET, ADDR_1, PORT_1, 0);
if (CHECK(server_fd < 0, sched, "start_mptcp_server: %d\n", errno))
@@ -469,8 +459,17 @@ static void send_data_and_verify(char *sched, char *addr1, char *addr2)
if (CHECK(client_fd < 0, sched, "connect_to_fd: %d\n", errno))
goto close_server;
+ if (clock_gettime(CLOCK_MONOTONIC, &start) < 0)
+ goto close_server;
+
send_data(server_fd, client_fd, sched);
+ if (clock_gettime(CLOCK_MONOTONIC, &end) < 0)
+ goto close_server;
+
+ delta_ms = (end.tv_sec - start.tv_sec) * 1000 + (end.tv_nsec - start.tv_nsec) / 1000000;
+ printf("%s: %u ms\n", sched, delta_ms);
+
if (!strcmp(addr1, "WITH_DATA"))
CHECK(has_bytes_sent(ADDR_1), sched, "should have bytes_sent on addr1\n");
else if (!strcmp(addr1, "WITHOUT_DATA"))
--
2.40.1