[PATCH mptcp-next v6 0/9] refactor mptcp bpf tests

Geliang Tang posted 9 patches 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1712235379.git.tanggeliang@kylinos.cn
There is a newer version of this series
.../testing/selftests/bpf/prog_tests/mptcp.c  | 265 +++++-------------
.../selftests/bpf/progs/mptcp_bpf_bkup.c      |   1 +
.../selftests/bpf/progs/mptcp_bpf_burst.c     |   1 +
.../selftests/bpf/progs/mptcp_bpf_first.c     |   1 +
.../selftests/bpf/progs/mptcp_bpf_red.c       |   1 +
.../selftests/bpf/progs/mptcp_bpf_rr.c        |   1 +
6 files changed, 77 insertions(+), 193 deletions(-)
[PATCH mptcp-next v6 0/9] refactor mptcp bpf tests
Posted by Geliang Tang 1 month ago
From: Geliang Tang <tanggeliang@kylinos.cn>

v6:
- drop patch 1 in v5 and rebased.

v5:
 - drop patch 5 in v4:
  Squash to "selftests/bpf: Add bpf scheduler test" 4 cleanup

v4:
 - add set_nonblock to make BPF tests stable.
 - split 'Squash to "selftests/bpf: Add bpf scheduler test"' into 4 patches.

v3:
 - part 1, bpf schedulers.

v2:
 - add two more helpers, send_single_byte and send_recv_data.

Refactor mptcp bpf tests using newly added macros MPTCP_BASE_TEST,
RUN_MPTCP_TEST and MPTCP_SCHED_TEST macro.

Geliang Tang (9):
  selftests/bpf: Add RUN_MPTCP_TEST macro
  Squash to "selftests/bpf: Add bpf scheduler test" 1 verify
  Squash to "selftests/bpf: Add bpf scheduler test" 2 time
  selftests/bpf: Add MPTCP_SCHED_TEST macro
  Squash to "selftests/bpf: Add bpf_first scheduler & test"
  Squash to "selftests/bpf: Add bpf_bkup scheduler & test"
  Squash to "selftests/bpf: Add bpf_rr scheduler & test"
  Squash to "selftests/bpf: Add bpf_red scheduler & test"
  Squash to "selftests/bpf: Add bpf_burst scheduler & test"

 .../testing/selftests/bpf/prog_tests/mptcp.c  | 265 +++++-------------
 .../selftests/bpf/progs/mptcp_bpf_bkup.c      |   1 +
 .../selftests/bpf/progs/mptcp_bpf_burst.c     |   1 +
 .../selftests/bpf/progs/mptcp_bpf_first.c     |   1 +
 .../selftests/bpf/progs/mptcp_bpf_red.c       |   1 +
 .../selftests/bpf/progs/mptcp_bpf_rr.c        |   1 +
 6 files changed, 77 insertions(+), 193 deletions(-)

-- 
2.40.1
Re: [PATCH mptcp-next v6 0/9] refactor mptcp bpf tests
Posted by Matthieu Baerts 1 month ago
Hi Geliang,

On 04/04/2024 15:03, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v6:
> - drop patch 1 in v5 and rebased.
> 
> v5:
>  - drop patch 5 in v4:
>   Squash to "selftests/bpf: Add bpf scheduler test" 4 cleanup
> 
> v4:
>  - add set_nonblock to make BPF tests stable.
>  - split 'Squash to "selftests/bpf: Add bpf scheduler test"' into 4 patches.
> 
> v3:
>  - part 1, bpf schedulers.
> 
> v2:
>  - add two more helpers, send_single_byte and send_recv_data.
> 
> Refactor mptcp bpf tests using newly added macros MPTCP_BASE_TEST,
> RUN_MPTCP_TEST and MPTCP_SCHED_TEST macro.

Thank you for the cleanup.

Please see my comments on the different patches.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-next v6 0/9] refactor mptcp bpf tests
Posted by MPTCP CI 1 month ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8555399820

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/c7b5767b70ce
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=841431


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)