From: Geliang Tang <tanggeliang@kylinos.cn>

v5:
 - merge the squash-to patch
 - rename cnt1/2/3 as Matt suggested. (thanks)

v4:
 - address Mat's comments for v3 (thanks).
 - merge patch 1 and patch 2 into one.

v3:
 - address Matt's comments for patch 3 (thanks)
 - add "dport", "sleep", and mptcp_lib_expect_all_features.

v2:
 - address Mat's comments for v1 (thanks)
 - set msk->last_data_sent only if err > 0
 - set last_data_recv in __mptcp_move_skbs_from_subflow
 - add three reserved bytes after mptcpi_subflows_total
 - move selftests from mptcp_join.sh to diag.sh and check that the
timestamps move forward.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/446

Geliang Tang (2):
  mptcp: add last time fields in mptcp_info
  selftests: mptcp: test last time mptcp_info

 include/uapi/linux/mptcp.h                |  4 ++
 net/mptcp/options.c                       |  1 +
 net/mptcp/protocol.c                      |  7 ++++
 net/mptcp/protocol.h                      |  3 ++
 net/mptcp/sockopt.c                       |  4 ++
 tools/testing/selftests/net/mptcp/diag.sh | 51 +++++++++++++++++++++++
 6 files changed, 70 insertions(+)

-- 
2.40.1

Hi Geliang, Mat,

On 02/04/2024 14:52, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v5:
>  - merge the squash-to patch
>  - rename cnt1/2/3 as Matt suggested. (thanks)

Thank you for the last version and the reviews!

New patches for t/upstream:
- 86f4ac812473: mptcp: add last time fields in mptcp_info
- 39e0a5698a69: selftests: mptcp: test last time mptcp_info
- e2a5795fc295: Squash to "selftests: mptcp: test last time mptcp_info"
- Results: f6f31f972b24..5194dc9f4bb2 (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/92e1f1e61b8c9332430e4797d5cb1bf6f408c1aa/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.

On Tue, 2 Apr 2024, Geliang Tang wrote:

> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> v5:
> - merge the squash-to patch
> - rename cnt1/2/3 as Matt suggested. (thanks)

v5 LGTM (with Matthieu's suggestions), thanks Geliang!


Reviewed-by: Mat Martineau <martineau@kernel.org>

>
> v4:
> - address Mat's comments for v3 (thanks).
> - merge patch 1 and patch 2 into one.
>
> v3:
> - address Matt's comments for patch 3 (thanks)
> - add "dport", "sleep", and mptcp_lib_expect_all_features.
>
> v2:
> - address Mat's comments for v1 (thanks)
> - set msk->last_data_sent only if err > 0
> - set last_data_recv in __mptcp_move_skbs_from_subflow
> - add three reserved bytes after mptcpi_subflows_total
> - move selftests from mptcp_join.sh to diag.sh and check that the
> timestamps move forward.
>
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/446
>
> Geliang Tang (2):
>  mptcp: add last time fields in mptcp_info
>  selftests: mptcp: test last time mptcp_info
>
> include/uapi/linux/mptcp.h                |  4 ++
> net/mptcp/options.c                       |  1 +
> net/mptcp/protocol.c                      |  7 ++++
> net/mptcp/protocol.h                      |  3 ++
> net/mptcp/sockopt.c                       |  4 ++
> tools/testing/selftests/net/mptcp/diag.sh | 51 +++++++++++++++++++++++
> 6 files changed, 70 insertions(+)
>
> -- 
> 2.40.1
>
>
>

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8523400120

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/8821889c37c6
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=840625


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)