[v8] add helpers and vars in mptcp_lib.sh, part 3

[PATCH mptcp-next v8 0/6] add helpers and vars in mptcp_lib.sh, part 3

Geliang Tang posted 6 patches 2 months, 1 week ago

Diff against v1 v2 v3 v4 v5 v6 v7 v9 v10 v11 v12 v13
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1709273774.git.tanggeliang@kylinos.cn

There is a newer version of this series

tools/testing/selftests/net/mptcp/diag.sh     | 19 ++---
.../selftests/net/mptcp/mptcp_connect.sh      | 76 ++++++++++---------
.../testing/selftests/net/mptcp/mptcp_join.sh | 28 +++----
.../testing/selftests/net/mptcp/mptcp_lib.sh  | 45 ++++++++---
.../selftests/net/mptcp/mptcp_sockopt.sh      | 33 ++++----
.../testing/selftests/net/mptcp/pm_netlink.sh |  5 +-
.../selftests/net/mptcp/simult_flows.sh       | 14 ++--
.../selftests/net/mptcp/userspace_pm.sh       | 22 ++----
8 files changed, 131 insertions(+), 111 deletions(-)

Expand all Fold all

[PATCH mptcp-next v8 0/6] add helpers and vars in mptcp_lib.sh, part 3

Posted by Geliang Tang 2 months, 1 week ago

From: Geliang Tang <tanggeliang@kylinos.cn>

v8:
 - address every comment from Matt in v7.

v7:
 - address every comment from Matt in v6.

v6:
 - only include the first 7 patches in v5
 - add mptcp_lib_pr_* helpers
 - add print_title helpers
 - align the output of simult_flows.sh

v5:
 - don't use mptcp_lib_print_test_counter in mptcp_join.sh, it breaks
   skip_test().

v4:
 - set test_cnt to 0, use ++counter in mptcp_lib_print_test_counter() to
   fix the following mismatched test counters:

# 012 userspace pm server fullmesh
#       syn                                 [ OK ]
#       synack                              [ OK ]
#       ack                                 [ OK ]
#       add                                 [ OK ]
#       echo                                [FAIL] got 1 ADD_ADDR echo[s] expected 2
# Server ns stats
# TcpPassiveOpens                 5                  0.0
# TcpInSegs                       25                 0.0
... ...
#
# 1 failure(s) has(ve) been detected:
#       - 13: userspace pm server fullmesh

v3:
 - fix shellcheck errors in v2

v2:
 - fix shellcheck errors in v1
 - print test results with counters

Geliang Tang (6):
  selftests: mptcp: connect: add dedicated port counter
  selftests: mptcp: connect: fix misaligned output
  selftests: mptcp: print all error messages to stdout
  selftests: mptcp: add test counter helpers
  selftests: mptcp: print test results with counters
  selftests: mptcp: print test results with colors

 tools/testing/selftests/net/mptcp/diag.sh     | 19 ++---
 .../selftests/net/mptcp/mptcp_connect.sh      | 76 ++++++++++---------
 .../testing/selftests/net/mptcp/mptcp_join.sh | 28 +++----
 .../testing/selftests/net/mptcp/mptcp_lib.sh  | 45 ++++++++---
 .../selftests/net/mptcp/mptcp_sockopt.sh      | 33 ++++----
 .../testing/selftests/net/mptcp/pm_netlink.sh |  5 +-
 .../selftests/net/mptcp/simult_flows.sh       | 14 ++--
 .../selftests/net/mptcp/userspace_pm.sh       | 22 ++----
 8 files changed, 131 insertions(+), 111 deletions(-)

-- 
2.40.1