From: Geliang Tang <tanggeliang@kylinos.cn>

v5:
 - don't use mptcp_lib_print_test_counter in mptcp_join.sh, it breaks
   skip_test().

v4:
 - set test_cnt to 0, use ++counter in mptcp_lib_print_test_counter() to
   fix the following mismatched test counters:

# 012 userspace pm server fullmesh
#       syn                                 [ OK ]
#       synack                              [ OK ]
#       ack                                 [ OK ]
#       add                                 [ OK ]
#       echo                                [FAIL] got 1 ADD_ADDR echo[s] expected 2
# Server ns stats
# TcpPassiveOpens                 5                  0.0
# TcpInSegs                       25                 0.0
... ...
#
# 1 failure(s) has(ve) been detected:
#       - 13: userspace pm server fullmesh

v3:
 - fix shellcheck errors in v2

v2:
 - fix shellcheck errors in v1
 - print test results with counters

Geliang Tang (12):
  selftests: mptcp: capitalize ok/fail/skip
  selftests: mptcp: sockopt: print every test result
  selftests: mptcp: connect: fix misaligned OK/FAIL
  selftests: mptcp: print test results with colors
  selftests: mptcp: connect: add dedicated port counter
  selftests: mptcp: connect: print out ping tests info
  selftests: mptcp: print test results with counters
  selftests: mptcp: move test_fail out of check_expected_one
  selftests: mptcp: extract mptcp_lib_check_expected
  selftests: mptcp: export event macros in mptcp_lib
  selftests: mptcp: add mptcp_lib_verify_listener_events
  selftests: mptcp: use KSFT_SKIP/KSFT_PASS/KSFT_FAIL

 tools/testing/selftests/net/mptcp/diag.sh     |  20 +-
 .../selftests/net/mptcp/mptcp_connect.sh      |  85 ++++---
 .../testing/selftests/net/mptcp/mptcp_join.sh |  67 ++----
 .../testing/selftests/net/mptcp/mptcp_lib.sh  |  94 +++++++-
 .../selftests/net/mptcp/mptcp_sockopt.sh      |  34 ++-
 .../testing/selftests/net/mptcp/pm_netlink.sh |  11 +-
 .../selftests/net/mptcp/simult_flows.sh       |  15 +-
 .../selftests/net/mptcp/userspace_pm.sh       | 210 +++++++-----------
 8 files changed, 295 insertions(+), 241 deletions(-)

-- 
2.40.1

Hi Geliang,

On 26/02/2024 10:43, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v5:
>  - don't use mptcp_lib_print_test_counter in mptcp_join.sh, it breaks
>    skip_test().
> 
> v4:
>  - set test_cnt to 0, use ++counter in mptcp_lib_print_test_counter() to
>    fix the following mismatched test counters:
> 
> # 012 userspace pm server fullmesh
> #       syn                                 [ OK ]
> #       synack                              [ OK ]
> #       ack                                 [ OK ]
> #       add                                 [ OK ]
> #       echo                                [FAIL] got 1 ADD_ADDR echo[s] expected 2
> # Server ns stats
> # TcpPassiveOpens                 5                  0.0
> # TcpInSegs                       25                 0.0
> ... ...
> #
> # 1 failure(s) has(ve) been detected:
> #       - 13: userspace pm server fullmesh
> 
> v3:
>  - fix shellcheck errors in v2
> 
> v2:
>  - fix shellcheck errors in v1
>  - print test results with counters

Thank you for the new version fixing shellcheck errors.

Note that it is not easy to review this series with all the
modifications everywhere. Hopefully the new modifications will be
helpful for the maintenance and to spot issues.

Did you check that the messages in case of errors were all the same?

Please see the comments on the individual patches.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.