From: Geliang Tang <tanggeliang@kylinos.cn>

Depends on:
 - dump for userspace pm, v14

Geliang Tang (8):
  mptcp: make pm_remove_addrs_and_subflows static
  mptcp: drop duplicate header inclusions
  mptcp: update set_flags interfaces
  mptcp: set error messages for set_flags
  mptcp: drop lookup_by_id in lookup_addr
  mptcp: add use_id parameter for addresses_equal
  mptcp: add check_id for lookup_anno_list_by_saddr
  selftests: mptcp: flush userspace addrs list

 net/mptcp/diag.c                              |   1 -
 net/mptcp/mptcp_diag.c                        |   1 -
 net/mptcp/pm.c                                |  15 +--
 net/mptcp/pm_netlink.c                        | 120 +++++++++---------
 net/mptcp/pm_userspace.c                      |  47 +++++--
 net/mptcp/protocol.c                          |   1 -
 net/mptcp/protocol.h                          |  18 +--
 net/mptcp/subflow.c                           |   2 -
 .../testing/selftests/net/mptcp/mptcp_join.sh |  46 ++++++-
 9 files changed, 147 insertions(+), 104 deletions(-)

-- 
2.40.1

Hi Geliang,

On 21/02/2024 7:31 am, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> Depends on:
>  - dump for userspace pm, v14
> 
> Geliang Tang (8):
>   mptcp: make pm_remove_addrs_and_subflows static
>   mptcp: drop duplicate header inclusions
>   mptcp: update set_flags interfaces
>   mptcp: set error messages for set_flags
>   mptcp: drop lookup_by_id in lookup_addr
>   mptcp: add use_id parameter for addresses_equal
>   mptcp: add check_id for lookup_anno_list_by_saddr
>   selftests: mptcp: flush userspace addrs list

Thank you for this clean-up!

Patches 1-3, 5 look good to me. But I have some comments for the others.
I think patches 6-7 can be simplified by just using one new variable,
not sure about patch 8.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.